Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use native biome binary without node #31

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

luckydye
Copy link
Collaborator

No description provided.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biome has also support for musl. Any chance that zed gives us that information?

@luckydye
Copy link
Collaborator Author

I couldn't find anything. Also not sure if Zed even supports running on musl, since Linux support is also somewhat new.

@ematipico
Copy link
Member

Is it really a chore? I believe it's a feat or a breaking change, because it uses new APIs that zed didn't support before, so I suppose we require the latest of zed

@luckydye luckydye changed the title chore: use native biome binary without node feat: use native biome binary without node Jul 24, 2024
@luckydye
Copy link
Collaborator Author

Is it really a chore? I believe it's a feat or a breaking change, because it uses new APIs that zed didn't support before, so I suppose we require the latest of zed

Definitely xD

@luckydye luckydye merged commit be0e886 into main Jul 24, 2024
4 checks passed
@luckydye luckydye deleted the feat/use-native-binary branch July 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants