refactor(noEvolvingAny): rename into noEvolvingTypes (#2959)

biomejs · Jun 3, 2024 · 44b5c29 · 44b5c29
1 parent dad0fcb
commit 44b5c29
Show file tree

Hide file tree

Showing 22 changed files with 214 additions and 317 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -363,6 +363,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 - Make [useExhaustiveDependencies](https://biomejs.dev/linter/rules/use-exhaustive-dependencies/) report duplicate dependencies. Contributed by @tunamaguro
 
+- Rename `noEvolvingAny` into `noEvolvingTypes` ([#48](https://github.com/biomejs/website/issues/48)). Contributed by @Conaclos
+
 #### Bug fixes
 
 - [noUndeclaredVariables](https://biomejs.dev/linter/rules/no-undeclared-variables/) and [noUnusedImports](https://biomejs.dev/linter/rules/no-unused-imports) now correctly handle import namespaces ([#2796](https://github.com/biomejs/biome/issues/2796)).
@@ -1260,7 +1262,7 @@ The following rules are promoted:
 
 #### New features
 
-- Add rule [noEvolvingAny](https://biomejs.dev/linter/rules/no-evolving-any) to disallow variables from evolving into `any` type through reassignments. Contributed by @fujiyamaorange
+- Add rule [noEvolvingTypes](https://biomejs.dev/linter/rules/no-evolving-any) to disallow variables from evolving into `any` type through reassignments. Contributed by @fujiyamaorange
 
 #### Enhancements
 

diff --git a/.../tests/snapshots/main_cases_reporter_github/reports_diagnostics_github_check_command.snap b/.../tests/snapshots/main_cases_reporter_github/reports_diagnostics_github_check_command.snap
@@ -51,18 +51,10 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
 ::error title=lint/suspicious/noDebugger,file=main.ts,line=6,endLine=6,col=1,endColumn=9::This is an unexpected use of the debugger statement.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=main.ts,line=8,endLine=8,col=5,endColumn=6::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=main.ts,line=8,endLine=8,col=5,endColumn=6::This variable implicitly has the any type.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=main.ts,line=9,endLine=9,col=7,endColumn=8::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=main.ts,line=9,endLine=9,col=7,endColumn=8::This variable implicitly has the any type.
 ```
@@ -91,18 +83,10 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
 ::error title=lint/suspicious/noDebugger,file=index.ts,line=6,endLine=6,col=1,endColumn=9::This is an unexpected use of the debugger statement.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=index.ts,line=8,endLine=8,col=5,endColumn=6::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=index.ts,line=8,endLine=8,col=5,endColumn=6::This variable implicitly has the any type.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=index.ts,line=9,endLine=9,col=7,endColumn=8::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=index.ts,line=9,endLine=9,col=7,endColumn=8::This variable implicitly has the any type.
 ```

diff --git a/...cli/tests/snapshots/main_cases_reporter_github/reports_diagnostics_github_ci_command.snap b/...cli/tests/snapshots/main_cases_reporter_github/reports_diagnostics_github_ci_command.snap
@@ -51,18 +51,10 @@ ci ━━━━━━━━━━━━━━━━━━━━━━━━━
 ::error title=lint/suspicious/noDebugger,file=main.ts,line=6,endLine=6,col=1,endColumn=9::This is an unexpected use of the debugger statement.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=main.ts,line=8,endLine=8,col=5,endColumn=6::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=main.ts,line=8,endLine=8,col=5,endColumn=6::This variable implicitly has the any type.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=main.ts,line=9,endLine=9,col=7,endColumn=8::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=main.ts,line=9,endLine=9,col=7,endColumn=8::This variable implicitly has the any type.
 ```
@@ -91,18 +83,10 @@ ci ━━━━━━━━━━━━━━━━━━━━━━━━━
 ::error title=lint/suspicious/noDebugger,file=index.ts,line=6,endLine=6,col=1,endColumn=9::This is an unexpected use of the debugger statement.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=index.ts,line=8,endLine=8,col=5,endColumn=6::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=index.ts,line=8,endLine=8,col=5,endColumn=6::This variable implicitly has the any type.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=index.ts,line=9,endLine=9,col=7,endColumn=8::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=index.ts,line=9,endLine=9,col=7,endColumn=8::This variable implicitly has the any type.
 ```

diff --git a/...i/tests/snapshots/main_cases_reporter_github/reports_diagnostics_github_lint_command.snap b/...i/tests/snapshots/main_cases_reporter_github/reports_diagnostics_github_lint_command.snap
@@ -51,18 +51,10 @@ lint ━━━━━━━━━━━━━━━━━━━━━━━━━
 ::error title=lint/suspicious/noDebugger,file=main.ts,line=6,endLine=6,col=1,endColumn=9::This is an unexpected use of the debugger statement.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=main.ts,line=8,endLine=8,col=5,endColumn=6::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=main.ts,line=8,endLine=8,col=5,endColumn=6::This variable implicitly has the any type.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=main.ts,line=9,endLine=9,col=7,endColumn=8::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=main.ts,line=9,endLine=9,col=7,endColumn=8::This variable implicitly has the any type.
 ```
@@ -83,18 +75,10 @@ lint ━━━━━━━━━━━━━━━━━━━━━━━━━
 ::error title=lint/suspicious/noDebugger,file=index.ts,line=6,endLine=6,col=1,endColumn=9::This is an unexpected use of the debugger statement.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=index.ts,line=8,endLine=8,col=5,endColumn=6::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=index.ts,line=8,endLine=8,col=5,endColumn=6::This variable implicitly has the any type.
 ```
 
-```block
-::error title=lint/nursery/noEvolvingAny,file=index.ts,line=9,endLine=9,col=7,endColumn=8::This variable's type is not allowed to evolve implicitly, leading to potential any types.
-```
-
 ```block
 ::error title=lint/suspicious/noImplicitAnyLet,file=index.ts,line=9,endLine=9,col=7,endColumn=8::This variable implicitly has the any type.
 ```

diff --git a/...li/tests/snapshots/main_cases_reporter_junit/reports_diagnostics_junit_check_command.snap b/...li/tests/snapshots/main_cases_reporter_junit/reports_diagnostics_junit_check_command.snap
@@ -45,7 +45,7 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
 
 ```block
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="Biome" tests="16" failures="16" errors="20" time="<TIME>">
+<testsuites name="Biome" tests="12" failures="12" errors="16" time="<TIME>">
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noDoubleEquals" line="4" column="3">
             <failure message="Use === instead of ==.
@@ -58,21 +58,11 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
             <failure message="This is an unexpected use of the debugger statement.">line 5, col 0, This is an unexpected use of the debugger statement.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="8" column="5">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 7, col 4, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="8" column="5">
             <failure message="This variable implicitly has the any type.">line 7, col 4, This variable implicitly has the any type.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="9" column="7">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 8, col 6, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="9" column="7">
             <failure message="This variable implicitly has the any type.">line 8, col 6, This variable implicitly has the any type.</failure>
@@ -100,21 +90,11 @@ check ━━━━━━━━━━━━━━━━━━━━━━━━
             <failure message="This is an unexpected use of the debugger statement.">line 5, col 0, This is an unexpected use of the debugger statement.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="8" column="5">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 7, col 4, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="8" column="5">
             <failure message="This variable implicitly has the any type.">line 7, col 4, This variable implicitly has the any type.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="9" column="7">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 8, col 6, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="9" column="7">
             <failure message="This variable implicitly has the any type.">line 8, col 6, This variable implicitly has the any type.</failure>

diff --git a/...e_cli/tests/snapshots/main_cases_reporter_junit/reports_diagnostics_junit_ci_command.snap b/...e_cli/tests/snapshots/main_cases_reporter_junit/reports_diagnostics_junit_ci_command.snap
@@ -45,7 +45,7 @@ ci ━━━━━━━━━━━━━━━━━━━━━━━━━
 
 ```block
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="Biome" tests="16" failures="16" errors="20" time="<TIME>">
+<testsuites name="Biome" tests="12" failures="12" errors="16" time="<TIME>">
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noDoubleEquals" line="4" column="3">
             <failure message="Use === instead of ==.
@@ -58,21 +58,11 @@ ci ━━━━━━━━━━━━━━━━━━━━━━━━━
             <failure message="This is an unexpected use of the debugger statement.">line 5, col 0, This is an unexpected use of the debugger statement.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="8" column="5">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 7, col 4, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="8" column="5">
             <failure message="This variable implicitly has the any type.">line 7, col 4, This variable implicitly has the any type.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="9" column="7">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 8, col 6, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="9" column="7">
             <failure message="This variable implicitly has the any type.">line 8, col 6, This variable implicitly has the any type.</failure>
@@ -100,21 +90,11 @@ ci ━━━━━━━━━━━━━━━━━━━━━━━━━
             <failure message="This is an unexpected use of the debugger statement.">line 5, col 0, This is an unexpected use of the debugger statement.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="8" column="5">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 7, col 4, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="8" column="5">
             <failure message="This variable implicitly has the any type.">line 7, col 4, This variable implicitly has the any type.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="9" column="7">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 8, col 6, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="9" column="7">
             <failure message="This variable implicitly has the any type.">line 8, col 6, This variable implicitly has the any type.</failure>

diff --git a/...cli/tests/snapshots/main_cases_reporter_junit/reports_diagnostics_junit_lint_command.snap b/...cli/tests/snapshots/main_cases_reporter_junit/reports_diagnostics_junit_lint_command.snap
@@ -45,7 +45,7 @@ lint ━━━━━━━━━━━━━━━━━━━━━━━━━
 
 ```block
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="Biome" tests="16" failures="16" errors="16" time="<TIME>">
+<testsuites name="Biome" tests="12" failures="12" errors="12" time="<TIME>">
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noDoubleEquals" line="4" column="3">
             <failure message="Use === instead of ==.
@@ -58,21 +58,11 @@ lint ━━━━━━━━━━━━━━━━━━━━━━━━━
             <failure message="This is an unexpected use of the debugger statement.">line 5, col 0, This is an unexpected use of the debugger statement.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="8" column="5">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 7, col 4, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="8" column="5">
             <failure message="This variable implicitly has the any type.">line 7, col 4, This variable implicitly has the any type.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="9" column="7">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 8, col 6, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="main.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="9" column="7">
             <failure message="This variable implicitly has the any type.">line 8, col 6, This variable implicitly has the any type.</failure>
@@ -100,21 +90,11 @@ lint ━━━━━━━━━━━━━━━━━━━━━━━━━
             <failure message="This is an unexpected use of the debugger statement.">line 5, col 0, This is an unexpected use of the debugger statement.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="8" column="5">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 7, col 4, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="8" column="5">
             <failure message="This variable implicitly has the any type.">line 7, col 4, This variable implicitly has the any type.</failure>
         </testcase>
     </testsuite>
-    <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
-        <testcase name="org.biome.lint.nursery.noEvolvingAny" line="9" column="7">
-            <failure message="This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.">line 8, col 6, This variable&apos;s type is not allowed to evolve implicitly, leading to potential any types.</failure>
-        </testcase>
-    </testsuite>
     <testsuite name="index.ts" tests="1" disabled="0" errors="0" failures="1" package="org.biome">
         <testcase name="org.biome.lint.suspicious.noImplicitAnyLet" line="9" column="7">
             <failure message="This variable implicitly has the any type.">line 8, col 6, This variable implicitly has the any type.</failure>