feat(cli): Avoid secondary loop

biomejs · Nov 6, 2023 · 4965124 · 4965124
1 parent b9bf5ef
commit 4965124
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/crates/biome_cli/src/execute/traverse.rs b/crates/biome_cli/src/execute/traverse.rs
@@ -569,22 +569,20 @@ fn process_messages(options: ProcessMessagesOptions) {
         }
     }
 
-    for diagnostic in &diagnostics_to_print {
-        console.error(markup! {
-            {if verbose { PrintDiagnostic::verbose(diagnostic) } else { PrintDiagnostic::simple(diagnostic) }}
-        });
-    }
-
     let running_on_github = matches!(
         mode.traversal_mode(),
         TraversalMode::CI {
             environment: Some(ExecutionEnvironment::GitHub),
         }
     );
 
-    if running_on_github {
-        for diagnostic in diagnostics_to_print {
-            console.log(markup! {{PrintGitHubDiagnostic::simple(&diagnostic)}});
+    for diagnostic in &diagnostics_to_print {
+        console.error(markup! {
+            {if verbose { PrintDiagnostic::verbose(diagnostic) } else { PrintDiagnostic::simple(diagnostic) }}
+        });
+
+        if running_on_github {
+            console.log(markup! {{PrintGitHubDiagnostic::simple(diagnostic)}});
         }
     }