Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Nested arrow functions are split on multiple lines #1039

Closed
1 task done
ematipico opened this issue Dec 4, 2023 · 2 comments · Fixed by #1646
Closed
1 task done

📝 Nested arrow functions are split on multiple lines #1039

ematipico opened this issue Dec 4, 2023 · 2 comments · Fixed by #1646
Assignees
@kalleep
Labels
A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@ematipico
Copy link
Member

Environment information

main

Configuration

No response

Playground link

https://biomejs.dev/playground/?indentStyle=space&quoteStyle=single&trailingComma=none&code=YwBvAG4AcwB0ACAAbQBlAHMAcwBhAGcAZQBzACAAPQAgAHMAdABkAG8AdQB0AAoACQAJAC4AcwBwAGwAaQB0ACgAJwBcAG4AJwApAAoACQAJAC4AZgBpAGwAdABlAHIAKAAoAGwAbgApACAAPQA%2BACAAIQAhAGwAbgAuAHQAcgBpAG0AKAApACkACgAJAAkALgBtAGEAcAAoACgAbABuACkAIAA9AD4ACgAJAAkACQBsAG4ACgAJAAkACQAJAC4AcgBlAHAAbABhAGMAZQAoAC8AWwA92IDeAyVdAC8AZwAsACAAJwAnACkACgAJAAkACQAJAC4AcgBlAHAAbABhAGMAZQAoAC8AXABzACsALwBnACwAIAAnACAAJwApAAoACQAJAAkACQAuAHQAcgBpAG0AKAApAAoACQAJACkAOwA%3D

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico
Copy link
Member Author

FYI the issue comes from here: https://github.com/withastro/adapters/pull/79/files#diff-1d2a2b56ad20e7e5b13936929d10bebf30d56ffa7cdc64f686dff4ae6cfafb60

@ematipico ematipico mentioned this issue Dec 4, 2023
Merged
@ematipico ematipico added A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project labels Dec 4, 2023
@kalleep
Copy link
Contributor

kalleep commented Jan 22, 2024

I can take a look at this one. This does not seem to have anything to do with nested arrow function but rather something with call chains.

https://biomejs.dev/playground/?indentStyle=space&quoteStyle=single&trailingComma=none&code=YQAuAHMAKAAvAD3YgN492IDeLwApAC4AcwAoACkALgBzACgAKQA%3D

@kalleep kalleep mentioned this issue Jan 23, 2024
Merged
@oom- oom- mentioned this issue Nov 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalleep kalleep

Labels
A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(js_formatter): incorrect call chain break kalleep/biome
2 participants
@ematipico @kalleep