Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format with Biome #79

Merged
merged 5 commits into from
Dec 4, 2023
Merged

chore: format with Biome #79

merged 5 commits into from
Dec 4, 2023

Conversation

ematipico
Copy link
Member

Changes

This PR makes use of Biome to format the code

Testing

The current CI should pass

Docs

N/A

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: 314f033

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -555,8 +555,8 @@ export default function createIntegration(args?: Options): AstroIntegration {
const winningStrategy = notFoundIsSSR
? excludeStrategy
: includeStrategyLength <= excludeStrategyLength
? includeStrategy
: excludeStrategy;
? includeStrategy
Copy link
Member Author

@ematipico ematipico Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: this is the new formatting of ternaries in Prettier 3.1

"ignore": [
"**/dist",
"**/node_modules",
"**/fixtures",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we ignore the fixtures?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ematipico there was a reason, but I can't remember it.
I'm happy to enable it for fixtures :)

@ematipico ematipico force-pushed the chore/format-with-biome branch 2 times, most recently from 40c52f7 to a554989 Compare December 1, 2023 19:54
.replace(/[🚀┃]/g, '')
.replace(/\s+/g, ' ')
.trim()
);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I personally dislike that it is not formatted like:

.map((ln) =>
	ln.replace(/[🚀┃]/g, '').replace(/\s+/g, ' ').trim()
);

Copy link
Member Author

@ematipico ematipico Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bug, I will report it back in the Biome repository. Also, I think we have more fixes in the pipeline coming in the next release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a big proponent of this change. Happy to give a final review pass once CI doesn't fail anymore.

@ematipico ematipico force-pushed the chore/format-with-biome branch from a554989 to 314f033 Compare December 4, 2023 11:30
@ematipico ematipico merged commit 877de42 into main Dec 4, 2023
8 checks passed
@ematipico ematipico deleted the chore/format-with-biome branch December 4, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants