-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: format with Biome #79
Conversation
|
@@ -555,8 +555,8 @@ export default function createIntegration(args?: Options): AstroIntegration { | |||
const winningStrategy = notFoundIsSSR | |||
? excludeStrategy | |||
: includeStrategyLength <= excludeStrategyLength | |||
? includeStrategy | |||
: excludeStrategy; | |||
? includeStrategy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: this is the new formatting of ternaries in Prettier 3.1
"ignore": [ | ||
"**/dist", | ||
"**/node_modules", | ||
"**/fixtures", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we ignore the fixtures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ematipico there was a reason, but I can't remember it.
I'm happy to enable it for fixtures :)
40c52f7
to
a554989
Compare
.replace(/[🚀┃]/g, '') | ||
.replace(/\s+/g, ' ') | ||
.trim() | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I personally dislike that it is not formatted like:
.map((ln) =>
ln.replace(/[🚀┃]/g, '').replace(/\s+/g, ' ').trim()
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bug, I will report it back in the Biome repository. Also, I think we have more fixes in the pipeline coming in the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a big proponent of this change. Happy to give a final review pass once CI doesn't fail anymore.
a554989
to
314f033
Compare
Changes
This PR makes use of Biome to format the code
Testing
The current CI should pass
Docs
N/A