Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Glob syntax not fully supported #2316

Closed
1 task done
nckhmelkov opened this issue Apr 4, 2024 · 4 comments
Closed
1 task done

🐛 Glob syntax not fully supported #2316

nckhmelkov opened this issue Apr 4, 2024 · 4 comments

Comments

@nckhmelkov
Copy link

nckhmelkov commented Apr 4, 2024

Environment information

CLI:
  Version:                      1.6.4
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.11.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/1.22.21"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

Hello,
I tried to describe using Glob syntax a recursive check of all *.tsx and *.ts extension files existing in the src directory in the TS React project.
According to Globset Docs it should be works correctly, but biome found not all matches.
Current examples are superficial, but get the point across
Please check screenshots:

biome check src/**/*.{ts,tsx} - AR: Checked 1 file (src/utils/utils.ts) ER: Checked 6 files
image

biome check src/**/*.ts - AR: Checked 1 file (src/utils/utils.ts) ER: Checked 3 files
image

We have similar cases in our company project and currently it solves by
eslint --max-warnings 0 --ext .ts,.tsx src/

P.s biome check src/ works correctly

Expected result

All files *.ts and *.tsx from src directory should be matched

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico
Copy link
Member

It's a known limitation and we're aware of it. In fact, we don't document it: https://biomejs.dev/guides/how-biome-works/#glob-syntax-explained

We will eventually get there!

@nckhmelkov
Copy link
Author

Thanks for answer.

@Conaclos
Copy link
Member

Conaclos commented Apr 5, 2024

It's a known limitation and we're aware of it. In fact, we don't document it: https://biomejs.dev/guides/how-biome-works/#glob-syntax-explained

We will eventually get there!

I think the problem here is not a glob syntax Biome doesn't support, but the use of unsupported glob syntaxes in the invoked shell.

@ematipico
Copy link
Member

Oh didn't see that. Yeah, Biome doesn't support globs in the CLI. Closing as not a bug.

@ematipico ematipico closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants