Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Running
check:ts
oncheck:fix
Running
bun run check:fix
will now also run Typescript type-checking, if that package uses Typescript. Currently, runningcheck:fix
may pass, but runningcheck
immediately after may fail (because the check command does not also type-check). This makes thecheck:fix
command more indicative of the check status of the repository after it is completed, meaning you don't need to runcheck
aftercheck:fix
to be sure that tests will pass.Removing usage of unsupported glob syntax
Globstar (
**
) expansionThe biome check glob arguments behave differently on different shells. Running
biome check src/**/*.ts
directly in a shell has been seen to have different behavior than running that same command from within apackage.json
script, meaning that files that are deeply nested enough can escape linting and formatting.See related issue on Biome.
Brace expansion (
{a,b}
)Brace expansion is handled differently by different shells and has inconsistent behavior. Biome plans to implement it themselves; It will be released in v2. Until then, we should not use brace expansion, as it can lead to files not being tested.
Glob syntax solution:
This PR removes usages of brace and globstar expansion, instead directly checking directories and allowing Biome to check all files it has support for.
Un-formatted files have been formatted
Due to the above glob inconsistencies, some files were not being checked. They are now properly checked by Biome, and their changes have been added to this PR.
Consistent Biome dev dependency
Prior to this PR, some packages used Biome for formatting and linting but did not explicitly depend on it - their checking was only working because other packages in the monorepo depend on Biome. This PR adds explicit dev depencies on Biome where applicable.
I have also updated packages to use the latest version of Biome & its configuration schema.
Issues fixed
biome
devDependency for packages that use it #18PR readiness check
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
:build
,check
, andcheck:fix
.