feat(cli): support nested .gitignore and better glob patterns support

.gitignore

@@ -7,7 +7,7 @@ Profile-*.json
 # Release artifacts
 **/target
 # Ignore test files that contributors could create locally
-/test.*
+**/test.*
 # Ignore third-party files
 **/node_modules
 **/dist

CHANGELOG.md

@@ -17,9 +17,29 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 #### New features
 
 - The command `biome migrate` now updates the `$schema` if there's an outdated version.
+- The CLI now supports nested `.gitignore` files during the traversal. The users don't need to do anything to avail of this feature. Contributed by @ematipico
+- Fix [#709](https://github.com/biomejs/biome/issues/709), by correctly parsing allow list patterns in `.gitignore` files. Contributed by @ematipico
+- Fix [#805](https://github.com/biomejs/biome/issues/805), by correctly parsing these kind of patterns. Contributed by @ematipico
+
+- Fix [#1117](https://github.com/biomejs/biome/issues/1117) by correctly respecting the matching. Contributed by @ematipico
 
 ### Configuration
 
+#### New features
+
+- Users can specify git ignore patterns inside `ignore` and `include` properties, for example it's possible to **allow list** globs of files using the `!` character:
+
+  ```json5
+  {
+    "files": {
+      "ignore": [
+        "node_modules/**",
+        "!**/dist/**" // this is now accepted and allow list files inside the `dist` folder
+      ]
+    }
+  }
+  ```
+
 ### Editors
 
 #### New features

Cargo.toml

@@ -120,6 +120,7 @@ bitflags          = "2.3.1"
 bpaf              = { version = "0.9.5", features = ["derive"] }
 countme           = "3.0.1"
 dashmap           = "5.4.0"
+ignore            = "0.4.20"
 indexmap          = "1.9.3"
 insta             = "1.29.0"
 lazy_static       = "1.4.0"
@@ -132,9 +133,9 @@ serde             = { version = "1.0.163", features = ["derive"] }
 serde_json        = "1.0.96"
 smallvec          = { version = "1.10.0", features = ["union", "const_new"] }
 tracing           = { version = "0.1.37", default-features = false, features = ["std"] }
+unicode-bom       = "2.0.3"
 # pinning to version 1.18 to avoid multiple versions of windows-sys as dependency
-tokio       = { version = "~1.18.5" }
-unicode-bom = "2.0.3"
+tokio = { version = "~1.18.5" }
 
 
 [profile.dev.package.biome_wasm]

biome.json

@@ -1,18 +1,31 @@
 {
 	"$schema": "./packages/@biomejs/biome/configuration_schema.json",
 	"vcs": {
-		"enabled": true,
 		"clientKind": "git",
+		"enabled": true,
 		"useIgnoreFile": true
 	},
 	"files": {
-		"ignore": ["types.d.ts", "./editors/intellij"]
-	},
-	"formatter": {
 		"ignore": [
-			"configuration-schema.json"
+			"**/dist",
+			"**/.astro",
+			"**/assets",
+			"**/public",
+			"**/__snapshots__",
+			"**/editors/intellij/**",
+			"*.astro",
+			"*.mdx",
+			"*.md",
+			"*.css",
+			"*.scss",
+			"*.svg",
+			"*.png",
+			"*.yml"
 		]
 	},
+	"formatter": {
+		"ignore": ["configuration-schema.json"]
+	},
 	"linter": {
 		"enabled": true,
 		"rules": {

crates/biome_cli/Cargo.toml

@@ -38,6 +38,7 @@ bpaf                 = { workspace = true, features = ["bright-color"] }
 crossbeam            = "0.8.1"
 dashmap              = { workspace = true }
 hdrhistogram         = { version = "7.5.0", default-features = false }
+ignore               = { workspace = true }
 indexmap             = { workspace = true }
 lazy_static          = { workspace = true }
 rayon                = "1.5.1"

crates/biome_cli/src/commands/check.rs

@@ -1,13 +1,14 @@
 use crate::cli_options::CliOptions;
-use crate::configuration::{load_configuration, LoadedConfiguration};
-use crate::vcs::store_path_to_ignore_from_vcs;
+use crate::commands::validate_configuration_diagnostics;
 use crate::{
     execute_mode, setup_cli_subscriber, CliDiagnostic, CliSession, Execution, TraversalMode,
 };
 use biome_service::configuration::organize_imports::OrganizeImports;
-use biome_service::configuration::{FormatterConfiguration, LinterConfiguration};
+use biome_service::configuration::{
+    load_configuration, FormatterConfiguration, LinterConfiguration, LoadedConfiguration,
+};
 use biome_service::workspace::{FixFileMode, UpdateSettingsParams};
-use biome_service::{Configuration, MergeWith};
+use biome_service::{Configuration, ConfigurationBasePath, MergeWith};
 use std::ffi::OsString;
 use std::path::PathBuf;
 
@@ -54,9 +55,17 @@ pub(crate) fn check(
         Some(FixFileMode::SafeAndUnsafeFixes)
     };
 
-    let loaded_configuration = load_configuration(&mut session, &cli_options)?.with_file_path();
+    let base_path = match cli_options.config_path.as_ref() {
+        None => ConfigurationBasePath::default(),
+        Some(path) => ConfigurationBasePath::FromUser(PathBuf::from(path)),
+    };
 
-    loaded_configuration.check_for_errors(session.app.console, cli_options.verbose)?;
+    let loaded_configuration = load_configuration(&session.app.fs, base_path)?;
+    validate_configuration_diagnostics(
+        &loaded_configuration,
+        session.app.console,
+        cli_options.verbose,
+    )?;
 
     let LoadedConfiguration {
         configuration: mut fs_configuration,
@@ -92,12 +101,8 @@ pub(crate) fn check(
 
     // check if support of git ignore files is enabled
     let vcs_base_path = configuration_path.or(session.app.fs.working_directory());
-    store_path_to_ignore_from_vcs(
-        &mut session,
-        &mut fs_configuration,
-        vcs_base_path,
-        &cli_options,
-    )?;
+    let (vcs_base_path, gitignore_matches) =
+        fs_configuration.retrieve_gitignore_matches(&session.app.fs, vcs_base_path.as_deref())?;
 
     let stdin = if let Some(stdin_file_path) = stdin_file_path {
         let console = &mut session.app.console;
@@ -112,12 +117,15 @@ pub(crate) fn check(
     } else {
         None
     };
+    let vcs_enabled = fs_configuration.is_vcs_enabled();
 
     session
         .app
         .workspace
         .update_settings(UpdateSettingsParams {
             configuration: fs_configuration,
+            vcs_base_path,
+            gitignore_matches,
         })?;
 
     execute_mode(
@@ -128,5 +136,6 @@ pub(crate) fn check(
         session,
         &cli_options,
         paths,
+        vcs_enabled,
     )
 }