fix(ci): nextest on windows #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
approved these changes
May 16, 2024
Conaclos
approved these changes
May 16, 2024
It seems the root cause of it is the rustup change and nextest is just one that is affected by it. And on the contrary, nextest is going to release a new version that will fix this problem, so users are not required to add this environment variable themselves. |
|
The CI on Windows is working now :) |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After searching I believe the current failing CI jobs on Windows are caused by a recent rustup change that breaks nextests. So this PR uses the workaround mentioned by those smart minds that were also affected by and fixed this problem.
Refs:
cargo nextest run --workspacefails with DLL missing if a macro lib exists nextest-rs/nextest#1493Test Plan
Merge to main and check whether the CI on Windows will succeed.