feat(graphql_analyze): noDuplicatedFields

[vohoanglong0107]

Summary

Implement no-duplicate-fields lint rule from graphql-eslint

Test Plan

All tests should pass.

[codspeed-hq]

CodSpeed Performance Report

Merging #3308 will degrade performances by 6.23%

_{Comparing vohoanglong0107:feat-no-duplicated-fields (2bf29fb) with main (8834e26)}

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 105 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	vohoanglong0107:feat-no-duplicated-fields	Change
⚡	dojo_11880045762646467684.js[cached]	8.6 ms	8 ms	+6.47%
⚡	router_14177007973872119684.ts[cached]	2.3 ms	2.1 ms	+6.71%
❌	db_2930068967297060348.json[cached]	12.5 ms	13.3 ms	-6.23%

[ematipico]

Since this rule comes from an existing one, you should add the source: https://github.com/biomejs/biome/blob/main/crates/biome_analyze/CONTRIBUTING.md#biome-lint-rules-inspired-by-other-lint-rules

Not sure if we should do the same for the other rule

[vohoanglong0107]

Ah yes, I forgot about that. The other rule also has an equivalent version in graphql-eslint, I guess it makes sense to also add a source for it

[ematipico]

You'll have to rebase, and change declare_rule to declare_lint_rule

[vohoanglong0107]

Ah, sorry I didn't see your comment. Thanks for rebasing this for me

[ematipico]

Just one nit @vohoanglong0107, we should avoid having the language name inside the rule's name. We already have the metadata that tells us the language.

[vohoanglong0107]

I'm a little confused about this, but what if there is another rule for JSON called noDuplicatedFields, how could we config both of them?

[ematipico]

That's the beauty of this analyzer. A rule should work across languages, and the infrastructure will take care of it. Imagine the a11y rules, they need to work both in JSX and HTML.

The infrastructure and the website still needs some final touches, but we'll get there.

[vohoanglong0107]

Ahah, I understand. I will keep this in mind when developing further lint rules

[ematipico]

Feel free to merge it :)