fix(noUndeclaredDependencies): ignore invalid package names, bun import, and recognize Definitely Typed #3893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3874
Fix #3872
We now ensure that the package name is valid before checking if it is a dependency.
Note that I deliberately accepted some invalid package names (package names starting with an underscore and package name with uppercase character) in order to catch users' typo errors.
We also ignore
bun
imports.This looks fair because the NPM module named
bun
is from thebun
runtime.Test Plan
I added some tests.