Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): allow readonly modifier on indexParameter in useNamingConvention #4286

Merged

Conversation

sepruko
Copy link
Contributor

@sepruko sepruko commented Oct 14, 2024

Summary

Does not change any defaults, and adds a changelog entry. Closes #4277.

Test Plan

Updated snapshots to include readonly index signatures.

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Oct 14, 2024
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #4286 will degrade performances by 22.18%

Comparing sepruko:fix/use-naming-convention-readonly-index-param (0f3056c) with main (7bab172)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 103 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main sepruko:fix/use-naming-convention-readonly-index-param Change
big5-added_15586211152145260264.json[cached] 437.2 µs 561.8 µs -22.18%
db_17847247775464589309.json[cached] 13.8 ms 12.8 ms +7.85%

@sepruko sepruko force-pushed the fix/use-naming-convention-readonly-index-param branch from 812b5f2 to 717b4a9 Compare October 14, 2024 09:00
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Unfortunately, you accidentally formatted the CHANGELOG. This is causing a lot of unwanted changes. Could you please fix this?

@sepruko sepruko force-pushed the fix/use-naming-convention-readonly-index-param branch from 717b4a9 to 29670d5 Compare October 14, 2024 10:19
@sepruko
Copy link
Contributor Author

sepruko commented Oct 14, 2024

Looks good to me! Unfortunately, you accidentally formatted the CHANGELOG. This is causing a lot of unwanted changes. Could you please fix this?

Oops! I was wondering why the PR diff was so large... All fixed now.

@Conaclos Conaclos merged commit 88405b7 into biomejs:main Oct 14, 2024
12 checks passed
Conaclos added a commit that referenced this pull request Oct 18, 2024
…vention` (#4286)

Co-authored-by: Victorien Elvinger <victorien@elvinger.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useNamingConvention forbids the readonly modifier for indexParameter selector kind
2 participants