Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more test case for defer import parser #4303

Merged
merged 1 commit into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b

#### New features

- JS Parser support defer attribute in import statements ([#4215](https://github.com/biomejs/biome/issues/4215)).
- Add support for parsing the defer attribute in import statements ([#4215](https://github.com/biomejs/biome/issues/4215)).

```js
import defer * as myModule from "my-module";
Expand Down
3 changes: 3 additions & 0 deletions crates/biome_js_parser/src/syntax/module.rs
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ fn parse_import_clause(p: &mut JsParser) -> ParsedSyntax {

// test js import_defer_clause
// import defer * as yNamespace from "y";
//
// test_err js import_defer_clause
// import type defer * as yNamespace from "y";
if p.at(T![defer]) && p.nth_at(1, T![*]) {
p.eat(T![defer]);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import type defer * as yNamespace from "y";
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
JsModule {
bom_token: missing (optional),
interpreter_token: missing (optional),
directives: JsDirectiveList [],
items: JsModuleItemList [
JsImport {
import_token: IMPORT_KW@0..7 "import" [] [Whitespace(" ")],
import_clause: JsImportDefaultClause {
type_token: missing (optional),
default_specifier: JsDefaultImportSpecifier {
local_name: JsIdentifierBinding {
name_token: IDENT@7..12 "type" [] [Whitespace(" ")],
},
},
from_token: missing (required),
source: missing (required),
assertion: missing (optional),
},
semicolon_token: missing (optional),
},
JsBogusStatement {
items: [
DEFER_KW@12..18 "defer" [] [Whitespace(" ")],
STAR@18..20 "*" [] [Whitespace(" ")],
AS_KW@20..23 "as" [] [Whitespace(" ")],
IDENT@23..34 "yNamespace" [] [Whitespace(" ")],
FROM_KW@34..39 "from" [] [Whitespace(" ")],
JS_STRING_LITERAL@39..42 "\"y\"" [] [],
],
},
JsEmptyStatement {
semicolon_token: SEMICOLON@42..43 ";" [] [],
},
],
eof_token: EOF@43..44 "" [Newline("\n")] [],
}

0: JS_MODULE@0..44
0: (empty)
1: (empty)
2: JS_DIRECTIVE_LIST@0..0
3: JS_MODULE_ITEM_LIST@0..43
0: JS_IMPORT@0..12
0: IMPORT_KW@0..7 "import" [] [Whitespace(" ")]
1: JS_IMPORT_DEFAULT_CLAUSE@7..12
0: (empty)
1: JS_DEFAULT_IMPORT_SPECIFIER@7..12
0: JS_IDENTIFIER_BINDING@7..12
0: IDENT@7..12 "type" [] [Whitespace(" ")]
2: (empty)
3: (empty)
4: (empty)
2: (empty)
1: JS_BOGUS_STATEMENT@12..42
0: DEFER_KW@12..18 "defer" [] [Whitespace(" ")]
1: STAR@18..20 "*" [] [Whitespace(" ")]
2: AS_KW@20..23 "as" [] [Whitespace(" ")]
3: IDENT@23..34 "yNamespace" [] [Whitespace(" ")]
4: FROM_KW@34..39 "from" [] [Whitespace(" ")]
5: JS_STRING_LITERAL@39..42 "\"y\"" [] []
2: JS_EMPTY_STATEMENT@42..43
0: SEMICOLON@42..43 ";" [] []
4: EOF@43..44 "" [Newline("\n")] []
--
import_defer_clause.js:1:13 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× expected `from` but instead found `defer`

> 1 │ import type defer * as yNamespace from "y";
│ ^^^^^
2 │

i Remove defer

--
import type defer * as yNamespace from "y";
Loading