-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): analyzer plugin #4396
Merged
Merged
+602
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Area: project
A-Linter
Area: linter
L-JavaScript
Language: JavaScript and super languages
A-Diagnostic
Area: diagnostocis
L-Grit
Language: GritQL
labels
Oct 27, 2024
arendjr
force-pushed
the
analyzer-plugin
branch
from
October 27, 2024 13:11
2800953
to
f2e6781
Compare
arendjr
force-pushed
the
analyzer-plugin
branch
from
October 27, 2024 13:15
f2e6781
to
cab8651
Compare
arendjr
force-pushed
the
analyzer-plugin
branch
from
October 27, 2024 13:37
cab8651
to
5a6408b
Compare
CodSpeed Performance ReportMerging #4396 will degrade performances by 7.79%Comparing Summary
Benchmarks breakdown
|
arendjr
commented
Oct 27, 2024
@@ -11,7 +11,8 @@ impl WithinCompiler { | |||
context: &mut NodeCompilationContext, | |||
) -> Result<Within<GritQueryContext>, CompileError> { | |||
let pattern = PatternCompiler::from_maybe_curly_node(&node.pattern()?, context)?; | |||
let until = None; // TODO: Update syntax. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a separate PR for this one: #4399
ematipico
pushed a commit
that referenced
this pull request
Oct 31, 2024
ematipico
pushed a commit
that referenced
this pull request
Nov 7, 2024
ematipico
pushed a commit
that referenced
this pull request
Nov 27, 2024
ematipico
pushed a commit
that referenced
this pull request
Nov 27, 2024
ematipico
pushed a commit
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Diagnostic
Area: diagnostocis
A-Linter
Area: linter
A-Project
Area: project
A-Tooling
Area: internal tools
L-Grit
Language: GritQL
L-JavaScript
Language: JavaScript and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first iteration of the JS analyzer plugin with Grit. I added the following plugin as a showcase in the tests:
There are additional arguments to the
register_diagnostic()
function as well, but they are intended for the fixer, which is currently unsupported. Before being able to implement fixers, I'll have to get rewriting in GritQL working as well, so that'll take a bunch of some extra effort.This also required an upgrade to the GritQL engine again, since I had to get built-in functions (like
register_diagnostic()
) working in predicate position first: getgrit/gritql#557Test Plan
Test added.