Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove once_cell crate #4409

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Oct 28, 2024

Summary

Remove the remaining instance of once_cell::Lazy.

Test Plan

CI must pass.

@github-actions github-actions bot added the A-Tooling Area: internal tools label Oct 28, 2024
@Conaclos Conaclos force-pushed the conaclos/remove-once-cell branch from e6ddbd3 to 79668b8 Compare October 28, 2024 17:26
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48420 48420 0
Passed 47220 47220 0
Failed 1200 1200 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6580 6580 0
Passed 2205 2205 0
Failed 4375 4375 0
Panics 0 0 0
Coverage 33.51% 33.51% 0.00%

ts/babel

Test result main count This PR count Difference
Total 680 680 0
Passed 607 607 0
Failed 73 73 0
Panics 0 0 0
Coverage 89.26% 89.26% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18507 18507 0
Passed 14167 14167 0
Failed 4340 4340 0
Panics 0 0 0
Coverage 76.55% 76.55% 0.00%

@Conaclos Conaclos merged commit f9d278a into main Oct 28, 2024
13 checks passed
@Conaclos Conaclos deleted the conaclos/remove-once-cell branch October 28, 2024 17:38
Copy link

codspeed-hq bot commented Oct 28, 2024

CodSpeed Performance Report

Merging #4409 will not alter performance

Comparing conaclos/remove-once-cell (79668b8) with main (eb13885)

Summary

✅ 99 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant