fix(noUnusedImports): don't report used val imported as type in an external module #4597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3895
This PR changes how we bind ambient read to imported type.
Previously, we waited to get in the global scope to try binding an ambient read (read of a value in an ambient context) to an
import type
. However, external modules and namespaces can also import stuff.I changed the code to support it in any scope.
Test Plan
I added a test