refactor: protect scanned files against closing by LSP

crates/biome_cli/src/execute/migrate.rs

@@ -71,6 +71,7 @@ pub(crate) fn run(migrate_payload: MigratePayload) -> Result<(), CliDiagnostic>
         content: FileContent::FromClient(biome_config_content.to_string()),
         version: 0,
         document_file_source: Some(JsonFileSource::json().into()),
+        persist_node_cache: false,
     })?;
     let parsed = parse_json_with_cache(
         &biome_config_content,

crates/biome_cli/src/execute/mod.rs

@@ -544,6 +544,7 @@ pub fn execute_mode(
                         path: report_file.clone(),
                         version: 0,
                         document_file_source: None,
+                        persist_node_cache: false,
                     })?;
                     let code = session.app.workspace.format_file(FormatFileParams {
                         path: report_file.clone(),

crates/biome_cli/src/execute/process_file/workspace_file.rs

@@ -41,6 +41,7 @@ impl<'ctx, 'app> WorkspaceFile<'ctx, 'app> {
                 path: biome_path,
                 version: 0,
                 content: FileContent::FromClient(input.clone()),
+                persist_node_cache: false,
             },
         )
         .with_file_path_and_code(path.display().to_string(), category!("internalError/fs"))?;

crates/biome_cli/src/execute/std_in.rs

@@ -50,6 +50,7 @@ pub(crate) fn run<'a>(
                 version: 0,
                 content: FileContent::FromClient(content.into()),
                 document_file_source: None,
+                persist_node_cache: false,
             })?;
             let printed = workspace.format_file(FormatFileParams {
                 path: biome_path.clone(),
@@ -82,6 +83,7 @@ pub(crate) fn run<'a>(
             version: 0,
             content: FileContent::FromClient(content.into()),
             document_file_source: None,
+            persist_node_cache: false,
         })?;
         // apply fix file of the linter
         let file_features = workspace.file_features(SupportsFeatureParams {

crates/biome_fs/src/path.rs

@@ -193,6 +193,10 @@ impl BiomePath {
     pub fn is_to_inspect(&self) -> bool {
         self.kind.contains(FileKind::Inspectable)
     }
+
+    pub fn to_path_buf(&self) -> PathBuf {
+        self.path.clone()
+    }
 }
 
 #[cfg(feature = "serde")]
@@ -214,6 +218,12 @@ impl Deref for BiomePath {
     }
 }
 
+impl From<BiomePath> for PathBuf {
+    fn from(path: BiomePath) -> Self {
+        path.path
+    }
+}
+
 impl PartialOrd for BiomePath {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
         Some(self.cmp(other))

crates/biome_lsp/src/handlers/text_document.rs

@@ -34,6 +34,7 @@ pub(crate) async fn did_open(
         version,
         content: FileContent::FromClient(content),
         document_file_source: Some(language_hint),
+        persist_node_cache: true,
     })?;
 
     session.insert_document(url.clone(), doc);

crates/biome_lsp/src/server.rs

@@ -372,7 +372,9 @@ impl LanguageServer for LSPServer {
                 let result = self
                     .session
                     .workspace
-                    .unregister_project_folder(UnregisterProjectFolderParams { path: project_path })
+                    .unregister_project_folder(UnregisterProjectFolderParams {
+                        path: project_path.into(),
+                    })
                     .map_err(into_lsp_error);
 
                 if let Err(err) = result {

crates/biome_service/src/lib.rs

@@ -2,7 +2,6 @@ pub mod documentation;
 pub mod file_handlers;
 
 pub mod matcher;
-mod scanner;
 pub mod settings;
 pub mod workspace;
 

crates/biome_service/src/settings.rs

@@ -65,10 +65,16 @@ pub struct WorkspaceSettings {
 }
 
 impl WorkspaceSettings {
+    /// Returns the key of the current project.
     pub fn get_current_project_key(&self) -> ProjectKey {
         *self.current_project.read().unwrap()
     }
 
+    /// Sets which project is the current one by its key.
+    pub fn set_current_project(&self, key: ProjectKey) {
+        *self.current_project.write().unwrap() = key;
+    }
+
     /// Retrieves the settings of the current workspace folder
     pub fn get_current_settings(&self) -> Option<Settings> {
         trace!("Current key {:?}", self.current_project);
@@ -78,6 +84,15 @@ impl WorkspaceSettings {
             .map(|data| data.settings.clone())
     }
 
+    /// Retrieves the files settings of the current workspace folder
+    pub fn get_current_files_settings(&self) -> Option<FilesSettings> {
+        trace!("Current key {:?}", self.current_project);
+        self.data
+            .pin()
+            .get(&self.get_current_project_key())
+            .map(|data| data.settings.files.clone())
+    }
+
     /// Sets the settings of the current workspace folder.
     pub fn set_current_settings(&self, settings: Settings) {
         let data = self.data.pin();
@@ -95,15 +110,6 @@ impl WorkspaceSettings {
         data.insert(project_key, project_data);
     }
 
-    /// Retrieves the files settings of the current workspace folder
-    pub fn get_current_files_settings(&self) -> Option<FilesSettings> {
-        trace!("Current key {:?}", self.current_project);
-        self.data
-            .pin()
-            .get(&self.get_current_project_key())
-            .map(|data| data.settings.files.clone())
-    }
-
     pub fn get_current_manifest(&self) -> Option<PackageJson> {
         self.data
             .pin()
@@ -145,10 +151,10 @@ impl WorkspaceSettings {
     }
 
     /// Remove a project using its folder.
-    pub fn remove_project(&self, workspace_path: &Path) {
+    pub fn remove_project(&self, project_path: &Path) {
         let data = self.data.pin();
-        for (key, path_to_settings) in data.iter() {
-            if path_to_settings.path.as_path() == workspace_path {
+        for (key, project_data) in data.iter() {
+            if project_data.path.as_path() == project_path {
                 data.remove(key);
             }
         }
@@ -185,25 +191,24 @@ impl WorkspaceSettings {
 
     /// Checks whether the given `path` belongs to the current project and no
     /// other project.
-    pub fn path_belongs_only_to_current_project(&self, path: &BiomePath) -> bool {
-        let mut belongs_to_current = false;
+    pub fn path_belongs_only_to_project_with_path(
+        &self,
+        path: &BiomePath,
+        project_path: &Path,
+    ) -> bool {
+        let mut belongs_to_project = false;
         let mut belongs_to_other = false;
-        for (key, path_to_settings) in self.data.pin().iter() {
-            if path.strip_prefix(path_to_settings.path.as_path()).is_ok() {
-                if *key == self.get_current_project_key() {
-                    belongs_to_current = true;
+        for project_data in self.data.pin().values() {
+            if path.strip_prefix(project_data.path.as_path()).is_ok() {
+                if project_data.path.as_path() == project_path {
+                    belongs_to_project = true;
                 } else {
                     belongs_to_other = true;
                 }
             }
         }
 
-        belongs_to_current && !belongs_to_other
-    }
-
-    /// Sets which project is the current one by its key.
-    pub fn set_current_project(&self, key: ProjectKey) {
-        *self.current_project.write().unwrap() = key;
+        belongs_to_project && !belongs_to_other
     }
 
     /// Returns the maximum file size setting.

crates/biome_service/src/workspace.rs

@@ -52,6 +52,7 @@
 //!     format a file with a language that does not have a formatter
 
 mod client;
+mod scanner;
 mod server;
 
 pub use self::client::{TransportRequest, WorkspaceClient, WorkspaceTransport};
@@ -541,6 +542,14 @@ pub struct OpenFileParams {
     pub content: FileContent,
     pub version: i32,
     pub document_file_source: Option<DocumentFileSource>,
+
+    /// Set to `true` to persist the node cache used during parsing, in order to
+    /// speed up subsequent reparsing if the document has been edited.
+    ///
+    /// This should only be enabled if reparsing is to be expected, such as when
+    /// the file is opened through the LSP Proxy.
+    #[serde(default)]
+    pub persist_node_cache: bool,
 }
 
 #[derive(Debug, serde::Serialize, serde::Deserialize)]
@@ -966,7 +975,7 @@ pub struct RegisterProjectFolderParams {
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
 #[serde(rename_all = "camelCase")]
 pub struct UnregisterProjectFolderParams {
-    pub path: BiomePath,
+    pub path: PathBuf,
 }
 
 pub trait Workspace: Send + Sync + RefUnwindSafe {
@@ -1032,7 +1041,8 @@ pub trait Workspace: Send + Sync + RefUnwindSafe {
 
     /// Unregisters a workspace project folder.
     ///
-    /// The settings that belong to that project are deleted.
+    /// The settings that belong to that project are deleted. Any open files that belong to the
+    /// project are also closed.
     ///
     /// If a file watcher was registered as a result of a call to `scan_project_folder()`, it will
     /// also be unregistered.

crates/biome_service/src/scanner.rs → crates/biome_service/src/workspace/scanner.rs

@@ -16,6 +16,8 @@ use crate::diagnostics::Panic;
 use crate::workspace::{DocumentFileSource, FileContent, OpenFileParams};
 use crate::{Workspace, WorkspaceError};
 
+use super::server::WorkspaceServer;
+
 pub(crate) struct ScanResult {
     /// Diagnostics reported while scanning the project.
     pub diagnostics: Vec<Diagnostic>,
@@ -24,7 +26,10 @@ pub(crate) struct ScanResult {
     pub duration: Duration,
 }
 
-pub(crate) fn scan(workspace: &dyn Workspace, folder: &Path) -> Result<ScanResult, WorkspaceError> {
+pub(crate) fn scan(
+    workspace: &WorkspaceServer,
+    folder: &Path,
+) -> Result<ScanResult, WorkspaceError> {
     init_thread_pool();
 
     let (interner, _path_receiver) = PathInterner::new();
@@ -133,7 +138,7 @@ impl DiagnosticsCollector {
 /// Context object shared between directory traversal tasks.
 pub(crate) struct ScanContext<'app> {
     /// [Workspace] instance.
-    pub(crate) workspace: &'app dyn Workspace,
+    pub(crate) workspace: &'app WorkspaceServer,
 
     /// File paths interner cache used by the filesystem traversal.
     interner: PathInterner,
@@ -188,11 +193,12 @@ impl<'app> TraversalContext for ScanContext<'app> {
 /// so panics are caught, and diagnostics are submitted in case of panic too.
 fn open_file(ctx: &ScanContext, path: &BiomePath) {
     match catch_unwind(move || {
-        ctx.workspace.open_file(OpenFileParams {
+        ctx.workspace.open_file_by_scanner(OpenFileParams {
             path: path.clone(),
             content: FileContent::FromServer,
             document_file_source: None,
             version: 0,
+            persist_node_cache: false,
         })
     }) {
         Ok(Ok(())) => {}