fix(biome_diagnostics): fix JetBrains relative file URLs should be clickable when given line and column numbers

CHANGELOG.md

@@ -12,6 +12,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 ## Unreleased
 
 - Fix [#4323](https://github.com/biomejs/biome/issues/4258), where `lint/a11y/useSemanticElement` accidentally showed recommendations for `role="searchbox"` instead of `role="search"`
+- Fix [#4875](https://github.com/biomejs/biome/issues/4875), where the Jetbrains IDE terminal would output unclickable, relative file path links to files. This does not fix paths without line and column numbers. Contributed by @Andrew-Chen-Wang
 
 ### Analyzer
 
@@ -41,6 +42,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 - `biome migrate eslint` now correctly handles ESLint configuration with `null` values in file lists ([#4740](https://github.com/biomejs/biome/issues/4740)).
   Contributed by @Conaclos
 
+- Fix [#4202](https://github.com/biomejs/biome/issues/4202), where the formatting of the test function was different from prettier. Contributed by @mdm317
+
 ### Configuration
 
 ### Editors
@@ -89,6 +92,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 - `noDuplicateProperties` now throws lint errors properly when we use `@supports` (fix [#4756](https://github.com/biomejs/biome/issues/4756)) Contributed by @mehm8128
 
+- Fix [#4719](https://github.com/biomejs/biome/issues/4719), `bracketSameLine` now performs as expected when a comment is placed before the last JSX attribute. Contributed by @bushuai
+
 ### JavaScript APIs
 
 ### Linter
@@ -350,6 +355,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 - [noUselessFragments](https://biomejs.dev/linter/rules/no-useless-fragments/) now handles `JsxAttributeInitializerClause`, ensuring that fragments inside expressions like `<A b=<></> />` are preserved. ([#4208](https://github.com/biomejs/biome/issues/4208)). Contributed by @MaxtuneLee
 
+- [useSortedClasses](https://biomejs.dev/linter/rules/use-sorted-classes/) now suggests code fixes that match the JSX quote style of the formatter ([#4855](https://github.com/biomejs/biome/issues/4855)). Contributed by @lucasweng
+
 ### Parser
 
 #### Bug fixes

Cargo.toml

@@ -184,7 +184,7 @@ getrandom          = "0.2.15"
 globset            = "0.4.15"
 ignore             = "0.4.23"
 indexmap           = { version = "2.7.0", features = ["serde"] }
-insta              = "1.41.1"
+insta              = "1.42.0"
 natord             = "1.0.9"
 oxc_resolver       = "3.0.3"
 proc-macro2        = "1.0.86"

benchmark/package.json

@@ -11,7 +11,7 @@
     "node": ">20.0.0"
   },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "8.18.1",
+    "@typescript-eslint/eslint-plugin": "8.19.1",
     "dprint": "0.48.0",
     "eslint": "9.17.0",
     "prettier": "3.3.3"

crates/biome_analyze/src/context.rs

@@ -17,6 +17,7 @@ pub struct RuleContext<'a, R: Rule> {
     file_path: &'a Path,
     options: &'a R::Options,
     preferred_quote: &'a PreferredQuote,
+    preferred_jsx_quote: &'a PreferredQuote,
     jsx_runtime: Option<JsxRuntime>,
 }
 
@@ -33,6 +34,7 @@ where
         file_path: &'a Path,
         options: &'a R::Options,
         preferred_quote: &'a PreferredQuote,
+        preferred_jsx_quote: &'a PreferredQuote,
         jsx_runtime: Option<JsxRuntime>,
     ) -> Result<Self, Error> {
         let rule_key = RuleKey::rule::<R>();
@@ -45,6 +47,7 @@ where
             file_path,
             options,
             preferred_quote,
+            preferred_jsx_quote,
             jsx_runtime,
         })
     }
@@ -168,6 +171,11 @@ where
         self.preferred_quote
     }
 
+    /// Returns the preferred JSX quote that should be used when providing code actions
+    pub fn as_preferred_jsx_quote(&self) -> &PreferredQuote {
+        self.preferred_jsx_quote
+    }
+
     /// Attempts to retrieve a service from the current context
     ///
     /// ```no_test

crates/biome_analyze/src/options.rs

@@ -65,6 +65,9 @@ pub struct AnalyzerConfiguration {
     /// Allows to choose a different quote when applying fixes inside the lint rules
     pub preferred_quote: PreferredQuote,
 
+    /// Allows to choose a different JSX quote when applying fixes inside the lint rules
+    pub preferred_jsx_quote: PreferredQuote,
+
     /// Indicates the type of runtime or transformation used for interpreting JSX.
     pub jsx_runtime: Option<JsxRuntime>,
 }
@@ -117,6 +120,10 @@ impl AnalyzerOptions {
     pub fn preferred_quote(&self) -> &PreferredQuote {
         &self.configuration.preferred_quote
     }
+
+    pub fn preferred_jsx_quote(&self) -> &PreferredQuote {
+        &self.configuration.preferred_jsx_quote
+    }
 }
 
 #[derive(Debug, Default)]

crates/biome_analyze/src/registry.rs

@@ -399,6 +399,7 @@ impl<L: Language + Default> RegistryRule<L> {
             let query_result = <R::Query as Queryable>::unwrap_match(params.services, query_result);
             let globals = params.options.globals();
             let preferred_quote = params.options.preferred_quote();
+            let preferred_jsx_quote = params.options.preferred_jsx_quote();
             let jsx_runtime = params.options.jsx_runtime();
             let options = params.options.rule_options::<R>().unwrap_or_default();
             let ctx = match RuleContext::new(
@@ -409,6 +410,7 @@ impl<L: Language + Default> RegistryRule<L> {
                 &params.options.file_path,
                 &options,
                 preferred_quote,
+                preferred_jsx_quote,
                 jsx_runtime,
             ) {
                 Ok(ctx) => ctx,

crates/biome_analyze/src/signals.rs

@@ -346,6 +346,7 @@ where
     fn diagnostic(&self) -> Option<AnalyzerDiagnostic> {
         let globals = self.options.globals();
         let preferred_quote = self.options.preferred_quote();
+        let preferred_jsx_quote = self.options.preferred_jsx_quote();
         let options = self.options.rule_options::<R>().unwrap_or_default();
         let ctx = RuleContext::new(
             &self.query_result,
@@ -355,6 +356,7 @@ where
             &self.options.file_path,
             &options,
             preferred_quote,
+            preferred_jsx_quote,
             self.options.jsx_runtime(),
         )
         .ok()?;
@@ -386,6 +388,7 @@ where
             &self.options.file_path,
             &options,
             self.options.preferred_quote(),
+            self.options.preferred_jsx_quote(),
             self.options.jsx_runtime(),
         )
         .ok();
@@ -435,6 +438,7 @@ where
             &self.options.file_path,
             &options,
             self.options.preferred_quote(),
+            self.options.preferred_jsx_quote(),
             self.options.jsx_runtime(),
         )
         .ok();

crates/biome_aria/src/roles.rs

@@ -238,7 +238,7 @@ impl AriaRoles {
 
     /// Given an element name and attributes, it returns the role associated with that element.
     /// If no explicit role attribute is present, an implicit role is returned.
-    fn get_role_by_element_name(&self, element: &impl Element) -> Option<AriaRole> {
+    pub fn get_role_by_element_name(&self, element: &impl Element) -> Option<AriaRole> {
         element
             .find_attribute_by_name(|name| name == "role")
             .as_ref()

crates/biome_aria_metadata/src/lib.rs

@@ -129,7 +129,7 @@ fn is_valid_html_id(id: &str) -> bool {
 }
 
 impl AriaRole {
-    /// Returns the first valid role from `values`, a space-separated list of roles.
+    /// Returns the first valid role from `roles`, a space-separated list of roles.
     ///
     /// If a role attribute has multiple values, the first valid role (specified role) will be used.
     /// See <https://www.w3.org/TR/2014/REC-wai-aria-implementation-20140320/#mapping_role>