Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ja): translate Architecture into Japanese #912

Merged
merged 10 commits into from
Nov 29, 2023

Conversation

seo1nk
Copy link
Contributor

@seo1nk seo1nk commented Nov 27, 2023

Summary

Partial work of #880 .
I've translated internals/architecture.mdx.

Test Plan

@seo1nk seo1nk requested a review from a team as a code owner November 27, 2023 18:22
@github-actions github-actions bot added the A-Website Area: website label Nov 27, 2023
Copy link
Contributor

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. I left some suggestions.

website/src/content/docs/ja/internals/architecture.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/internals/architecture.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/internals/architecture.mdx Outdated Show resolved Hide resolved
@Conaclos Conaclos changed the title doc(ja): translate Architecture into Japanese docs(ja): translate Architecture into Japanese Nov 28, 2023
seo1nk and others added 4 commits November 28, 2023 21:36
Co-authored-by: Takayuki Maeda <takoyaki0316@gmail.com>
Co-authored-by: Takayuki Maeda <takoyaki0316@gmail.com>
Co-authored-by: Takayuki Maeda <takoyaki0316@gmail.com>
@seo1nk
Copy link
Contributor Author

seo1nk commented Nov 28, 2023

@TaKO8Ki
Thank you, fix completed!

Copy link
Contributor

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one more suggestion. After addressing it, LGTM :)

website/src/content/docs/ja/internals/architecture.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@nissy-dev nissy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TaKO8Ki TaKO8Ki merged commit f25b240 into biomejs:main Nov 29, 2023
4 checks passed
@seo1nk seo1nk deleted the feature/ja-docs-architecture branch November 29, 2023 13:44
yossydev pushed a commit to yossydev/biome that referenced this pull request Dec 3, 2023
Co-authored-by: Takayuki Maeda <takoyaki0316@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants