Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid algebra/ode solver #446

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Hybrid algebra/ode solver #446

merged 8 commits into from
Oct 11, 2023

Conversation

teddygroves
Copy link
Member

@teddygroves teddygroves commented Oct 9, 2023

This change implements an idea we unsuccessfully tried a while ago, namely finding steady states using an algebra solver with an embedded ode solver as described here. It's now way easier than before thanks to the variadic algebra solver.

Sort of addresses #368: it's a hybrid solver but with the bdf solver not the adjoint solver.

Note that after this change there are two configuration options for solvers: ode_solver_config and algebra_solver_config. They are specified like this in config.toml:

[ode_solver_config]
rel_tol=1e-12

[algebra_solver_config]
abs_tol=1e-8
max_num_steps=1e5

Checklist:

  • Updated any relevant documentation
  • Add an adr doc if appropriate
  • Include links to any relevant issues in the description
  • Unit tests passing
  • Integration tests passing

@teddygroves teddygroves changed the title [WIP] Hybrid algebra/ode solver Hybrid algebra/ode solver Oct 10, 2023
Copy link
Contributor

@NicholasCowie NicholasCowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on most models tested

@teddygroves teddygroves merged commit 0ddf1b1 into main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants