-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle embedded quote in mmcif #619
Handle embedded quote in mmcif #619
Conversation
…split with _split_one_line() using regex.
@padix-key Could you take a look at this solution? |
a09e8ab
to
23f4e2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for preparing the fix! I have put a few suggestions into the review.
Thank you for your review. I will provide feedback as soon as possible. I will have time in the evening or during the weekend. |
Thanks for the benchmarks. I will look into your comments tomorrow. |
Seems like your approach seems the most efficient one (at least I could not come up with a better one). So only two discussions remain. |
Thank you for your review, I will finish this PR ASAP. |
not call _quote in to_single().
@padix-key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks again for delving into regex and the the thorough benchmarks.
fix #570
use 3 regex patterns to match fields in one line for handle embed quote in mmcif file:
GPT4 explain single_quote_pattern: