Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong band width calculation under some circumstances #723

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

padix-key
Copy link
Member

Currently align_banded() may return local alignments even if local=False under rare circumstances.

The problem was that band diagonals are trimmed to the size of the sequences (just to save memory), but under this cicumstances the band width is not updated. This allowed the trace to 'escape' the alignment band for low-scoring alignments leading to a premature traceback termination and thus local alignments instead of semi-global ones.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #723 will not alter performance

Comparing padix-key:alignment-fix (965e799) with main (0acb143)

Summary

✅ 47 untouched benchmarks

@padix-key padix-key merged commit a70ada1 into biotite-dev:main Dec 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant