Added test_traj; debloat #3
Conversation
|
An ARM runner image is seemingly assigned to our MacOS x86_64 job.
Is it possible, that we'll have to switch to MacOS 12/13 for these platforms |
….which for compatibility with Python 3.12+
|
Tests are correctly run for MacOS-ARM, therefore this platform is no longer omitted from wheel-testing. |
| | jq -Rc ' | ||
| if (contains("x86_64")) then | ||
| {"dist": ., "os": "macos-13"} | ||
| else | ||
| {"dist": ., "os": "macos-latest"} | ||
| end | ||
| ' \ |
There was a problem hiding this comment.
Nice idea! This is about fixing the performance issues in arm builds right?
There was a problem hiding this comment.
Oh, I haven't checked the performance on ARM yet.
It seems macos-latest + x86_64 is not supported and it always defaulted to macos-latest + ARM for that setting.
According to the compatibility table, we have to use macos-13 + x86_64 or macos-latest-large + x86_64:
https://github.com/actions/runner-images?tab=readme-ov-file#available-images
If there are no downsides for macos-latest-large, we could switch to the latter.
There was a problem hiding this comment.
Large runners are seemingly only available for enterprise customers.
Let's keep macos-13, then.
…or trailing whitespaces and newlines Co-authored-by: Patrick Kunzmann <padix.key@gmail.com>
Added main tests for Trajectory objects.
Tests for unused formats were removed/commented out.
Tests for correct centering of trajectories were also removed (depends on MDTraj's RMSD
implementation; already present in main Biotite library).
Removed geometry-related functions from trajectory.py as well as ./geometry.