-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop 五段化 potential rule #2047
Drop 五段化 potential rule #2047
Conversation
Verbs that undergo 五段化 use either できる or し得る as their potential form, rather than the す-Godan verb potential form (せる). The rule caused duplicates results for inputs like 宣せぬ / 宣せず.
…tentialOrPassive and Causative" This is no longer necessary after the removal of the 五段化 potential rule. Reverts commit f2d6dfc.
Sorry for catching this a little bit too late! I plan to add a rule for masu-stem + 得る/える/うる as a potential form. Or do you think it would be better to have a separate reason like |
Not at all. Thank you for catching this!
I think I lean towards more explicit rules letting potential mean the potential form students learn about in classrooms/textbooks and having a separate annotation for (Also, since JMdict already has two entries for あり得る, I guess we'll end up with triplicate results when looking up あり得る after adding this new rule? Maybe that's unavoidable?) |
Yeah, I'm a bit concerned about 見える as well, but I think as long as it's sorted correctly, it should be fine and not too confusing. What do you think? |
I don't suppose there's any way to explicitly detect and filter out those cases? Alternatively we could just add the +得る rule and not add the +える・+うる rules for now? |
While I believe it would be fairly simple to filter those out, I’m hesitant to do so because it feels somewhat arbitrary to me. I actually quite like it when entries like あり得る are "explained" through deinflection, as long as the "explanatory" entry is placed afterward. I can see directly that あり得る is a form of ある. Just adding 得る and not える and うる would be the way to go then, I think. |
Sounds good. We can reinvestigate enabling the える・うる patterns later if it proves useful. |
Follow-up to #2038.
I encountered duplicate results for inputs like 宣せぬ or 宣せず, which stemmed from the following rule:
After reading again this resource from JMdict, I realized that this rule is incorrect. Verbs undergoing 五段化 have either し得る or できる as their potential forms, not the す-Godan potential form (せる).
By dropping this incorrect rule, the issue is resolved, and we can also revert the previous commit that was intended to prevent invalid sequencing of potential forms.