jupyterhub: update to version 1.3.0 to include login terms patch #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of jupyterhub includes the login terms patch originally introduced in 8be8eea. This official login terms feature has a few enhancements: * no javascript dependency * pop-up reminder for user to check the checkbox Behavior change is the "Sign in" button is not longer disabled if unchecked. It simply does not work and reminds the user to check the checkbox if unchecked.
matprov
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of jupyterhub includes the login terms patch originally
introduced in 8be8eea (PR #104).
This official login terms feature has a few enhancements (see jupyterhub/jupyterhub#3264 (comment)):
Behavior change is the "Sign in" button is not longer disabled if
unchecked. It simply does not work and reminds the user to check the
checkbox if unchecked.
Before:
After:
