Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter: Restore terminal and allow recursive folder deletion #280

Merged

Commits on Jan 24, 2023

  1. jupyter: re-enable terminal for all users

    It was disabled to avoid malicious usage but with the monitoring in
    place and the demo account restricted to limited resources, it's
    probably safe to try enabling this again.
    
    For legitimate users, not having the terminal is pretty annoying.
    Should not penalize legit users for some rogue users.
    tlvu committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3a2bcb5 View commit details
    Browse the repository at this point in the history
  2. jupyter: allow recursive directory deletion

    This was not possible before since non-empty dir deletion was not possible.
    tlvu committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0e78b24 View commit details
    Browse the repository at this point in the history
  3. jupyter: typo in previous allow non-empty dir delete config

    The container died instantly on creation startup.
    tlvu committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    06f7c6f View commit details
    Browse the repository at this point in the history
  4. fix regression with the previous introduction of DELAYED_EVAL

    Fix this error found during autodeploy:
    ```
    fix GeoServer data dir permission on first run only, when data dir do not exist yet.
    + DATA_DIR='${DATA_PERSIST_ROOT}/geoserver'
    + '[' -n  ]
    + docker run --rm --name fix-geoserver-data-dir-perm --volume '${DATA_PERSIST_ROOT}/geoserver:/datadir' --env FIRST_RUN_ONLY bash:5.1.4 bash -xc 'if [ -z "$FIRST_RUN_ONLY" -o ! -f /datadir/global.xml ]; \
        then chown -R 1000:10001 /datadir; else echo "No execute."; fi'
    docker: Error response from daemon: create ${DATA_PERSIST_ROOT}/geoserver: "${DATA_PERSIST_ROOT}/geoserver" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
    See 'docker run --help'.
    ```
    tlvu committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6687185 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. env.local.example: no need for delayed eval since env.local file is a…

    …lways read last
    
    env.local will always have the latest updated values so no need for
    delayed eval.
    tlvu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4679b07 View commit details
    Browse the repository at this point in the history
  2. Revert "fix regression with the previous introduction of DELAYED_EVAL"

    This reverts commit 6687185.
    
    To be implemented better in a different PR.
    
    Francis proposed to centralize all the sourcing logic of default.env and
    env.local and calling process_delayed_eval in a same file so all scripts
    to not have to remember the loading sequence and we have a central
    location to update that loading sequence without having to edit all the
    scripts in the future.
    tlvu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a84d7cd View commit details
    Browse the repository at this point in the history
  3. Bump version: 1.22.8 → 1.22.9

    tlvu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    de1e51d View commit details
    Browse the repository at this point in the history