Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.1 #164

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Release 0.7.1 #164

merged 2 commits into from
Mar 25, 2021

Conversation

aulemahal
Copy link
Collaborator

Overview

This PR makes release 0.7.1. Also added updates to CHANGES.rst and AUTHORS.rst, we forgot to update those in the last PRs.
Ran bumpversion.

@aulemahal aulemahal requested a review from huard March 25, 2021 20:19
@aulemahal aulemahal merged commit 6b03e79 into master Mar 25, 2021
@aulemahal aulemahal deleted the release-0.7.1 branch March 25, 2021 20:40
@tlvu
Copy link
Collaborator

tlvu commented Mar 26, 2021

Curious, when was the tag v0.7.1 pushed? There is no DockerHub build for it !

@tlvu
Copy link
Collaborator

tlvu commented Mar 26, 2021

Just manually triggered a DockerHub build for v0.7.1.

@aulemahal
Copy link
Collaborator Author

Sorry, it's my first time doing a release! I pushed the tag with the last commit of this PR. I think I should have left github create the tag at the same time as the release, is that it?
Also, should I tag you when we push changes that "break" the notebooks? Or is this automated dockerhub build enough?

@tlvu
Copy link
Collaborator

tlvu commented Mar 26, 2021

Sorry, it's my first time doing a release! I pushed the tag with the last commit of this PR. I think I should have left github create the tag at the same time as the release, is that it?

You did everything right. Github do not create the tag. It should be created and pushed with the release PR. So looks like the DockerHub build trigger somehow did not work for that tag. Weird nothing changed for that automatic trigger that was working before. Let's blame network issues or the moon.

Also, should I tag you when we push changes that "break" the notebooks? Or is this automated dockerhub build enough?

Yes, let me know when you make a Finch release. Unfortunately the update of Finch into the PAVICS stack is still manual.

Everything is fine, don't worry. I am just the kind that like to find root causes when there's anomalies.

@huard
Copy link
Collaborator

huard commented Mar 26, 2021

I think Github creates the tag when we use the "Release" page (if it does not already exist).

@tlvu
Copy link
Collaborator

tlvu commented Mar 26, 2021

I think Github creates the tag when we use the "Release" page (if it does not already exist).

Oh I didn't know this "feature".

But I think we should just stick to the known working release procedure here https://github.com/bird-house/finch/blob/master/docs/source/dev_guide.rst#bump-a-new-version

I think this is what Pascal followed anyways so I think the glitch in this case is either Github not firing the trigger to DockerHub or DockerHub somehow did not receive or did not act on the trigger.

tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Mar 26, 2021
See Finch release PR bird-house/finch#164 for
more release info.

This update will fix the following Jenkins error introduced by
bird-house/finch#161 (comment):

```
12:37:00  _________ finch-master/docs/source/notebooks/finch-usage.ipynb::Cell 1 _________
12:37:00  Notebook cell execution failed
12:37:00  Cell 1: Cell outputs differ
12:37:00
12:37:00  Input:
12:37:00  help(wps.frost_days)
12:37:00
12:37:00  Traceback:
12:37:00   mismatch 'stdout'
12:37:00
12:37:00   assert reference_output == test_output failed:
12:37:00
12:37:00    'Help on meth...ut files.\n\n' == 'Help on meth...ut files.\n\n'
12:37:00    Skipping 70 identical leading characters in diff, use -v to show
12:37:00    - min=None, missing_options=None, check_missing='any', thresh='0 degC', freq='YS', variable=None, output_formats=None) method of birdy.client.base.WPSClient instance
12:37:00    + min=None, check_missing='any', cf_compliance='warn', data_validation='raise', thresh='0 degC', freq='YS', missing_options=None, variable=None, output_formats=None) method of birdy.client.base.WPSClient instance
12:37:00          Number of days where daily minimum temperatures are below 0.
12:37:00
12:37:00          Parameters
12:37:00          ----------
12:37:00          tasmin : ComplexData:mimetype:`application/x-netcdf`, :mimetype:`application/x-ogc-dods`
12:37:00              NetCDF Files or archive (tar/zip) containing netCDF files.
12:37:00          thresh : string
12:37:00              Freezing temperature.
12:37:00          freq : {'YS', 'MS', 'QS-DEC', 'AS-JUL'}string
12:37:00              Resampling frequency.
12:37:00          check_missing : {'any', 'wmo', 'pct', 'at_least_n', 'skip', 'from_context'}string
12:37:00              Method used to determine which aggregations should be considered missing.
12:37:00          missing_options : ComplexData:mimetype:`application/json`
12:37:00              JSON representation of dictionary of missing method parameters.
12:37:00    +     cf_compliance : {'log', 'warn', 'raise'}string
12:37:00    +         Whether to log, warn or raise when inputs have non-CF-compliant attributes.
12:37:00    +     data_validation : {'log', 'warn', 'raise'}string
12:37:00    +         Whether to log, warn or raise when inputs fail data validation checks.
12:37:00          variable : string
12:37:00              Name of the variable in the NetCDF file.
12:37:00
12:37:00          Returns
12:37:00          -------
12:37:00          output_netcdf : ComplexData:mimetype:`application/x-netcdf`
12:37:00              The indicator values computed on the original input grid.
12:37:00          output_log : ComplexData:mimetype:`text/plain`
12:37:00              Collected logs during process run.
12:37:00          ref : ComplexData:mimetype:`application/metalink+xml; version=4.0`
12:37:00              Metalink file storing all references to output files.
```
tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Mar 26, 2021
finch: update to version 0.7.1

See Finch release PR bird-house/finch#164 for more release info.

This update will fix the following Jenkins error introduced by bird-house/finch#161 (comment):

```
12:37:00  _________ finch-master/docs/source/notebooks/finch-usage.ipynb::Cell 1 _________
12:37:00  Notebook cell execution failed
12:37:00  Cell 1: Cell outputs differ
12:37:00
12:37:00  Input:
12:37:00  help(wps.frost_days)
12:37:00
12:37:00  Traceback:
12:37:00   mismatch 'stdout'
12:37:00
12:37:00   assert reference_output == test_output failed:
12:37:00
12:37:00    'Help on meth...ut files.\n\n' == 'Help on meth...ut files.\n\n'
12:37:00    Skipping 70 identical leading characters in diff, use -v to show
12:37:00    - min=None, missing_options=None, check_missing='any', thresh='0 degC', freq='YS', variable=None, output_formats=None) method of birdy.client.base.WPSClient instance
12:37:00    + min=None, check_missing='any', cf_compliance='warn', data_validation='raise', thresh='0 degC', freq='YS', missing_options=None, variable=None, output_formats=None) method of birdy.client.base.WPSClient instance
12:37:00          Number of days where daily minimum temperatures are below 0.
12:37:00
12:37:00          Parameters
12:37:00          ----------
12:37:00          tasmin : ComplexData:mimetype:`application/x-netcdf`, :mimetype:`application/x-ogc-dods`
12:37:00              NetCDF Files or archive (tar/zip) containing netCDF files.
12:37:00          thresh : string
12:37:00              Freezing temperature.
12:37:00          freq : {'YS', 'MS', 'QS-DEC', 'AS-JUL'}string
12:37:00              Resampling frequency.
12:37:00          check_missing : {'any', 'wmo', 'pct', 'at_least_n', 'skip', 'from_context'}string
12:37:00              Method used to determine which aggregations should be considered missing.
12:37:00          missing_options : ComplexData:mimetype:`application/json`
12:37:00              JSON representation of dictionary of missing method parameters.
12:37:00    +     cf_compliance : {'log', 'warn', 'raise'}string
12:37:00    +         Whether to log, warn or raise when inputs have non-CF-compliant attributes.
12:37:00    +     data_validation : {'log', 'warn', 'raise'}string
12:37:00    +         Whether to log, warn or raise when inputs fail data validation checks.
12:37:00          variable : string
12:37:00              Name of the variable in the NetCDF file.
12:37:00
12:37:00          Returns
12:37:00          -------
12:37:00          output_netcdf : ComplexData:mimetype:`application/x-netcdf`
12:37:00              The indicator values computed on the original input grid.
12:37:00          output_log : ComplexData:mimetype:`text/plain`
12:37:00              Collected logs during process run.
12:37:00          ref : ComplexData:mimetype:`application/metalink+xml; version=4.0`
12:37:00              Metalink file storing all references to output files.
```

Jenkins build with Finch notebooks passing against newer Finch: http://jenkins.ouranos.ca/job/ouranos-staging/job/lvupavics.ouranos.ca/45/console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants