switch waitress for gunicorn #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, that's a very clear PR describing the changes. I would suggest you copy/paste this description into the merge commit description to preserve it and make it available even if github is not available (ex: no network). |
cehbrecht
approved these changes
Oct 29, 2020
@fmigneault I think you can remove |
|
@fmigneault Thanks for the PR :) Feel free to merge. |
Fixes #97 Replaces `waitress` by `gunicorn` by default. `waitress` seems to do some kind of deduplication of contents with extra read/write of chucks during data streaming. Could not find any way to avoid `waitress` to do this with some option/flag. Tests results can be found here: - #97 (comment) - #97 (comment) Leaving waitress in dependencies so that pre-existing deploys can use whichever they want between `gunicorn` / `waitress`. Important note: `gunicorn > 20` needs to be started with `pserve` to have correct port assigned. There is a change of parsing `PasteDeploy` config where starting directly with `gunicorn` doesn't detect the right port. (doesn't matter that much in this case, since default is 8000 which is also the one employed) Regarless, Docker image was already using `pserve`, so everything should work just fine.
Merged
This was referenced Dec 8, 2020
fmigneault
added a commit
to Ouranosinc/Magpie
that referenced
this pull request
Dec 9, 2020
fmigneault
added a commit
to Ouranosinc/Magpie
that referenced
this pull request
Dec 9, 2020
bump twitcher v0.5.4 (performance fix bird-house/twitcher#98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
Replaces
waitressbygunicornby default.waitressseems to do some kind of deduplication of contents with extra read/write of chucks during data streaming.I could not find any way to avoid
waitressto do this with some option/flag.Tests results can be found here:
#97 (comment)
#97 (comment)
I leave
waitressin dependencies so that pre-existing deploys can use whichever they want betweengunicorn/waitress.(if this is not an issue, we can remove it also)
Important note:
gunicorn > 20needs to be started withpserveto have correct port assigned.There is a change of parsing PasteDeploy config where starting directly with
gunicorndoesn't detect the right port.(doesn't matter that much in this case, since default is
8000which is also the one employed)Regarless, Docker image was already using
pserve, so everything should work just fine.