Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump protoreflect to support optional fields in proto3 #159

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

aliellis
Copy link

@aliellis aliellis commented Aug 25, 2021

Heyhey, just something I encountered recently

We have an old version of protoreflect which means that you receive an error when parsing proto3 files with optional fields, this was fixed with protobuf 3.1.5 when support for optional fields was provided by default

Steps to recreate

  • Use latest version of kaf
  • Try to consume a message with a proto3 schema that contains Optional field

example proto

syntax="proto3";

// Address is the home address of the user.
message Address {
  optional string hello = 1;
  string world = 2;

More information on the change can be found here

@birdayz
Copy link
Owner

birdayz commented Aug 25, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants