Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying scopes in oauth config #309

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

bachmanity1
Copy link
Contributor

Although scopes is optional, some OIDC providers refuse to authenticate if scopes are not configured properly.

@bachmanity1
Copy link
Contributor Author

@birdayz can you plz have a look?

Copy link
Owner

@birdayz birdayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@bachmanity1
Copy link
Contributor Author

@birdayz thanks for the review! can we merge this and build a new version?

@birdayz birdayz merged commit 23dc332 into birdayz:master Mar 7, 2024
1 check passed
@bachmanity1 bachmanity1 deleted the add-scopes-config branch March 7, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants