Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http://mynode.local:3002 as a bitcoin block explorer #4634

Closed

Conversation

huey735
Copy link
Contributor

@huey735 huey735 commented Oct 13, 2020

No description provided.

@chimp1984
Copy link
Contributor

I get a page not found

@huey735
Copy link
Contributor Author

huey735 commented Oct 13, 2020

It is an implementation of btc-rpc-explorer that can be run with the Mynode project locally.

@chimp1984
Copy link
Contributor

Ah ok. I guess that might confuse other uses as well... Better might be to add a UI to enter a custom explorer or by prog arg.

@huey735
Copy link
Contributor Author

huey735 commented Oct 13, 2020

I find it unlikely. My guess is that most people don't change the default and those that do, choose one that they're familiar with. Anyways, maybe I can add little disclaimer to the name field
Mynode (requires dedicated node)

@cd2357
Copy link
Contributor

cd2357 commented Oct 13, 2020

Add http://mynode.local:3002 as a bitcoin block explorer

Or even https://custom-ip-or-hostname:3002

Some people run their own explorer on a raspi or some other host.

But that could be a future improvement.

@@ -98,7 +98,8 @@
new BlockChainExplorer("SoChain. Wow.", "https://chain.so/tx/BTC/", "https://chain.so/address/BTC/"),
new BlockChainExplorer("Blockchain.info", "https://blockchain.info/tx/", "https://blockchain.info/address/"),
new BlockChainExplorer("Insight", "https://insight.bitpay.com/tx/", "https://insight.bitpay.com/address/"),
new BlockChainExplorer("Blockchair", "https://blockchair.com/bitcoin/transaction/", "https://blockchair.com/bitcoin/address/")
new BlockChainExplorer("Blockchair", "https://blockchair.com/bitcoin/transaction/", "https://blockchair.com/bitcoin/address/"),
new BlockChainExplorer("Mynode.local", "http://mynode.local:3002/tx/", "http://mynode.local:3002/address/")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about calling it "Local BTC RPC Explorer"?

"BTC RPC Explorer" is the official name of the explorer project: https://github.com/janoside/btc-rpc-explorer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But no, its fine, please disregard that, its only a cosmetic thing.

@cd2357
Copy link
Contributor

cd2357 commented Oct 13, 2020

utACK

@huey735
Copy link
Contributor Author

huey735 commented Oct 13, 2020

@cd2357

Some people run their own explorer on a raspi or some other host.

@chimp1984

Ah ok. I guess that might confuse other uses as well... Better might be to add a UI to enter a custom explorer or by prog arg.

These two suggestions make sense together. Maybe it's worth to add custom field where the user would paste in the url because as @cd2357 said many people run their own block explorer. Be it btc-rpc-explorer, mempool.space, or other.

But implementing that in the UI is beyond my skills.

@dcod3d
Copy link
Contributor

dcod3d commented Oct 13, 2020

There's already an open issue for using custom block explorer #4371

But IMHO, a non public explorer should not be an option that's built into the app.

@cd2357
Copy link
Contributor

cd2357 commented Oct 13, 2020

But IMHO, a non public explorer should not be an option that's built into the app.

Why not?

Edit: I mean, Bisq allows people to use their own (non-public) bitcoin node. I don't see why letting them use their own (non-public) blockchain explorer would be a problem.

So from my side: ACK 👍

@dcod3d
Copy link
Contributor

dcod3d commented Oct 26, 2020

I agree that bisq should allow (even encourage) use of an user's own blockchain explorer. However, hard coding in one company's implementation (explorer/url) isn't the right way to do it.

@sqrrm
Copy link
Member

sqrrm commented Oct 27, 2020

NACK

It doesn't make sense to hard code a link that doesn't work for most people. This should be either a command line argument and/or a text field where the specific explorer could be added.

@ghost ghost mentioned this pull request Oct 31, 2020
@huey735
Copy link
Contributor Author

huey735 commented Nov 1, 2020

Better implemented on #4733

@huey735 huey735 closed this Nov 1, 2020
@huey735 huey735 deleted the add-mynode-block-explorer branch November 1, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants