Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Set Password text button #5272

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

BtcContributor
Copy link
Contributor

Fixes #3379

Now it looks like this:

bisq10

Copy link
Contributor

@wallclockbuilder wallclockbuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UtAck

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - It is kind of critical that the user understands what the setting of the password will cause. We know that users hardly read text so we want to prevent the user making a mistake. Maybe the text for the call to action should be more something like Set password (I have already made a backup) 👈 @m52go any ideas on a perfect condensed wording?

@BtcContributor
Copy link
Contributor Author

BtcContributor commented Mar 9, 2021

I didn't want to fill a button with too much text.

Maybe some part of the explanation text could be in bold?

We could also change from "Go to Account/Wallet seed" to "Make a backup".

@wallclockbuilder
Copy link
Contributor

Other wallets e.g. BlueWallet, CoboVault deal with this by requiring the user to confirm the backup seed before setting the password. This way you know for sure they backed up the seed and also got the correct seed.

@wallclockbuilder
Copy link
Contributor

For backups bisq can also verify. Ask user for backup location. Confirm backup directory signature matches current backup directory signature. Both signatures should match as long as both directories have the same files and structure.

@m52go
Copy link
Contributor

m52go commented Mar 11, 2021

Maybe some part of the explanation text could be in bold?

I don't think that's possible, unfortunately.

We could also change from "Go to Account/Wallet seed" to "Make a backup".

I like this suggestion. So maybe the green button can be "Set Password (I already made a backup)" and the other can be "Make Backup" which goes to Account > Backup. If it fits...

@BtcContributor
Copy link
Contributor Author

Pushed changes as stated by @m52go, thanks!

@BtcContributor BtcContributor requested a review from ripcurlx March 11, 2021 14:59
@ripcurlx ripcurlx merged commit caac1b4 into bisq-network:master Mar 11, 2021
@BtcContributor BtcContributor deleted the fixbackupbutton branch March 11, 2021 15:26
@ripcurlx ripcurlx added this to the v1.6.0 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

password is not saving
4 participants