-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Set Password text button #5272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UtAck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - It is kind of critical that the user understands what the setting of the password will cause. We know that users hardly read text so we want to prevent the user making a mistake. Maybe the text for the call to action should be more something like Set password (I have already made a backup)
👈 @m52go any ideas on a perfect condensed wording?
I didn't want to fill a button with too much text. Maybe some part of the explanation text could be in bold? We could also change from "Go to Account/Wallet seed" to "Make a backup". |
Other wallets e.g. BlueWallet, CoboVault deal with this by requiring the user to confirm the backup seed before setting the password. This way you know for sure they backed up the seed and also got the correct seed. |
For backups bisq can also verify. Ask user for backup location. Confirm backup directory signature matches current backup directory signature. Both signatures should match as long as both directories have the same files and structure. |
I don't think that's possible, unfortunately.
I like this suggestion. So maybe the green button can be "Set Password (I already made a backup)" and the other can be "Make Backup" which goes to |
Pushed changes as stated by @m52go, thanks! |
Fixes #3379
Now it looks like this: