Sort foreign alphabet payment methods above the untranslated ones. #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, JAVA sorts foreign characters below English characters. However, the payment methods that are translated are also more likely to be used by someone native to that language, so it makes better sense to sort as two separate sets and put the foreign language ones on top. This commit does that for payment methods.
|
Application was built and run to test and verify the sorting changed as expected, and nothing broken. See attached screenshot from Russian language mode with the change is applied, with an line drawn hand drawn to illustrate where the Russian ends and the English begins.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, JAVA sorts foreign characters below English characters. However, the payment methods that are translated are also more likely to be used by someone native to that language, so it makes better sense to sort as two separate lists and put the foreign language ones on top. This commit does just that for the payment methods list on the Accounts page.