-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language strings file cleanup; added missing, applied rename #7253
Language strings file cleanup; added missing, applied rename #7253
Conversation
The Bisq policy for displayStrings is stated in the comments at the beginning of the primary (English) file that all string keys should be present in all language files, even though fallthrough would otherwise result. In reviewing how well the language files actually comply with this rule, just 5 strings out 2,670 did not comply; these changes correct that and restore all language files to have all strings.
Tested that new strings load properly using a small Java applet:
Output from all languages on string tradeFeedbackWindow.msg.feedback: [main] INFO bisq.core.locale.GlobalSettings - Locale info: cs_US Pokud máte nějaké dotazy nebo máte nějaké problémy, obraťte se prosím na ostatní uživatele a přispěvatele prostřednictvím fóra Bisq na: [main] INFO bisq.core.locale.GlobalSettings - Locale info: de_US Sollten Sie Fragen oder Probleme haben, kontaktieren Sie andere Nutzer und Mitwirkende im Bisq-Forum auf: [main] INFO bisq.core.locale.GlobalSettings - Locale info: es_US Si tiene alguna pregunta o experimenta algún problema, por favor póngase en contacto con otros usuarios y colaboradores a través del foro Bisq en: [main] INFO bisq.core.locale.GlobalSettings - Locale info: fa_US اگر سوالی دارید یا مشکلی را تجربه کردهاید، لطفا با سایر کاربران و شرکت کننده ها از طریق انجمن Bisq که در ذیل ارائه شده، به اشتراک بگذارید: [main] INFO bisq.core.locale.GlobalSettings - Locale info: fr_US Si vous avez la moindre question, ou rencontrez un problème, veuillez s'il vous plaît vous mettre en relation avec les autres utilisateurs et contributeurs via le forum Bisq sur: [main] INFO bisq.core.locale.GlobalSettings - Locale info: it_US In caso di domande o problemi, si prega di mettersi in contatto con altri utenti e collaboratori tramite il forum Bisq all'indirizzo: [main] INFO bisq.core.locale.GlobalSettings - Locale info: ja_US ご質問がある場合、または問題が発生した場合は、次のBisqフォーラムで他のユーザーや貢献者に連絡してください: [main] INFO bisq.core.locale.GlobalSettings - Locale info: pl_US Jeśli masz jakiekolwiek pytania, lub doświadczyłeś problemów prosimy o kontakt z innymi użytkownikami i osobami które przyczyniają się do rozwoju Bisq na forum: [main] INFO bisq.core.locale.GlobalSettings - Locale info: en_US If you'd like to provide feedback, if you have any questions, or experienced any problems, please get in touch with other users and contributors via the Bisq forum at: [main] INFO bisq.core.locale.GlobalSettings - Locale info: pt-br_US Se você tem dúvidas ou está tendo problemas, por favor entre em contato com outros usuários e contribuidores através do fórum Bisq em: [main] INFO bisq.core.locale.GlobalSettings - Locale info: pt_US Se tiver alguma dúvida ou algum problema, entre em contacto com outros usuários e colaboradores através do fórum Bisq em: [main] INFO bisq.core.locale.GlobalSettings - Locale info: ru_US Если у вас возникли вопросы или сложности, свяжитесь с другими пользователями и разработчиками приложения на форуме Bisq: [main] INFO bisq.core.locale.GlobalSettings - Locale info: th_US หากคุณมีข้อสงสัยหรือประสบปัญหาใด ๆ โปรดติดต่อกับผู้ใช้และผู้สนับสนุนคนอื่น ๆ ผ่านทางฟอรัม Bisq ที่: [main] INFO bisq.core.locale.GlobalSettings - Locale info: vi_US nếu bạn có câu hỏi hay vấn đề, vui lòng liên hệ với người dùng khác và các nhàn đóng góp qua Bisq forum ở: [main] INFO bisq.core.locale.GlobalSettings - Locale info: zh-hans_US 如果您有任何疑问或遇到任何问题,请通过 Bisq 论坛与其他用户和贡献者联系: [main] INFO bisq.core.locale.GlobalSettings - Locale info: zh-hant_US 如果您有任何疑問或遇到任何問題,請通過 Bisq 論壇與其他用户和貢獻者聯繫: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Do you refer to " Please use in all language files the exact same order of the entries, that way a comparison is easier."?
This does not really mean that all language strings should be present in all language files. Not that familiar with Transifex workflow, but I assume its better to use the fallback. We discussed elsewhere already and can wait for response from @ripcurlx
I could try to gut all the English displayStrings out of the language files, but as I said this certainly appears to have been the practice, and I'd be literally removing thousands of strings that I never added to do it! Agree though it would make it easier for people when adding new strings, but I think it's way too late for that now. I'm aware Bisq1 is in maintenance mode and most devs are working on new Bisq2 functionality behind the scenes, though not sure how I could contribute with most of the project planning and feature requests happening behind the scenes. |
Ah ok. I was not aware that it was practice in Bisq 1 to add english strings.
Why do you think that? There is plenty of resources where one can see the things which are planned and in work: See also the high level bisq2 video at https://bisq.network/blog/bisq-2-now-in-beta |
The Bisq policy for displayStrings, as stated in the comments at the beginning of the primary (English) language properties file, is that all string keys should be present in all language files, even though fallthrough would otherwise result. In reviewing how well the language files actually comply with this rule, the following discrepancies were found and are fixed here:
tradeFeedbackWindow.msg.part1/2/3 apparently was changed at some point in the past to tradeFeedbackWindow.msg.feedback and tradeFeedbackWindow.msg.thanks. This change also involved removal of reference to a user survey in favor of redirecting users to a Bisq forums. However, that change was never applied to any of the language files, which meant fallthrough has been happening and the translations were not displaying.
filterWindow.addedSeedNodes and filterWindow.addedBtcNodes were never added to language files. These and the other filterWindow strings are used by desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java file, although that window itself seems to be dead code at present (I cannot find it in the application or how it would be launched by the code). This is may be a separate issue for a different pull request at a later time, depending on whether FilterWindow is deemed obsolete or if it is actually a new feature still in development.
Prerequsite to PR #7268