-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileView can not open symlinked folders #1476
Comments
The idea is that symbolic links shall only be opened if the link points to a folder inside of the current snapshot: backintime/common/snapshots.py Lines 2447 to 2465 in 2f7b609
I have tested this by creating a symbolic link in the source folder and point to a sub folder within the source folder
Edit: Stupid me, I had the "expert option" _Copy links (dereference symbolic links) activated so I have to retest all this... Test results:
So to fix this we need to decide if we want to Option b) is the easiest fix I think (by checking for the translated "Now"):
BTW:
|
This issue needs further investigation. I won't touch it yet because I'm in the middle of refactoring
qt/app.py
while I uncovered this issue.Reproduce:
The relevant code in the GUI is here:
backintime/qt/app.py
Lines 1338 to 1353 in 1003d36
In there the
self.sid.canOpenPath()
does returnFalse
.It is not a serious bug. But I have the feeling that touching this will cause some more trouble and much more need to refactor. There might be a big workload hidden behind it. 😄
The text was updated successfully, but these errors were encountered: