-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Open symlinked folders in fileview #1650
Conversation
I don't feel well merging this without proper review. So I am waiting. But there is no hurry. |
Sorry, I did review this (but without actually running the code) and the only thing I have found is the question about a better name for the Just propose a better name (or even decide to leave it as it is for now since there is a function doc string): backintime/common/snapshots.py Lines 2623 to 2632 in ed282ad
Is there something special I should test (eg. risky code change)? |
I won't have a chance for some time, but I'll be happy to test this in a VM. |
I renamed now and just used your proposal.
😁 It is primarily an irrational sensation. I lack a thorough understanding of that section of the code, which hinders me from realistically contemplating its implications. It's nothing serious, just a minor challenge. No meed to merge it soon. It can wait some weeks if Michael want to test it. |
Symlink folders in fileview now can be opened via double click in all circumstances.
I have to say that I am not sure about that solution or its implications. The related code is to complex (for me) to be sure.
But on my tests it worked.
Close #1476