Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debian-folder #1548

Closed
buhtz opened this issue Oct 2, 2023 · 6 comments · Fixed by #1733
Closed

Remove debian-folder #1548

buhtz opened this issue Oct 2, 2023 · 6 comments · Fixed by #1733
Assignees
Labels
Discussion decision or consensus needed Distro-Specific only for certain distributions, desktop environments or display servers Infrastructure Medium

Comments

@buhtz
Copy link
Member

buhtz commented Oct 2, 2023

The debian folder is used by Germar to create deb-files distributed via a PPA.

I propose to migrate that folder somewhere else. I would suggest to migrate it to Launchpad itself because Launchpad also host the related PPA.

That folder is specific to a bunch of GNU Linux distribution and therefor irrelevant for another bunch of distros (e.g. Arch based). This is no problem but natural. But it is not related to an upstream repository which should always be independent from a specific GNU Linux distribution or alternative distribution ways (Flatpak, Snap, ...). Things like this should maintained elsewhere.

Official Debian itself don't use this debian folder. Debian to have its own repository maintaining such a folder.

I'll contact Germar via mail.

@buhtz buhtz self-assigned this Oct 2, 2023
@buhtz buhtz added Distro-Specific only for certain distributions, desktop environments or display servers Infrastructure Discussion decision or consensus needed labels Oct 2, 2023
@buhtz buhtz added this to the 1.4.2 (upcoming release) milestone Oct 2, 2023
@buhtz buhtz added the Feedback needs user response, may be closed after timeout without a response label Oct 26, 2023
@Germar
Copy link
Member

Germar commented Nov 8, 2023

debian is used by makedeb-src.sh by me to create files for the PPA. But it is also used by makedeb.sh. I'm pretty sure, a lot users uses this to build their own .deb packages from source. I vote to keep debian. You can remove it from release tarball in make-tarball.sh so it won't disturb other distro maintainers any more

@buhtz
Copy link
Member Author

buhtz commented Nov 15, 2023

@buhtz
Copy link
Member Author

buhtz commented Dec 6, 2023

Dear Germar,

debian is used by makedeb-src.sh by me to create files for the PPA.

I am aware of that. That is why I suggested to move the PPA related files to Launchpad or an alternative repo. IMHO an upstream repo should be kept clean and independent from distro-specific technology. PPA is specific to Debian-based distros.

But it is also used by makedeb.sh. I'm pretty sure, a lot users uses this to build their own .deb packages from source.

I see no evidence for that. If users need the latest version of BIT they have alternative ways and can use the upstream repo (currently via make and with Python based build-system #1575 in the future) or the PPA. I see not much need to build their own deb file.
But even if they want to do it they just can do it without having a "debian" folder in this upstream repo. They can create that folder on their own or using the script in your separate repo I mentioned before.

Separate the "debian" folder into another repo would improve the infrastructure of the BIT project and make it easier to organize it.

@aryoda
Copy link
Contributor

aryoda commented Dec 7, 2023

Separate the "debian" folder into another repo would improve the infrastructure of the BIT project and make it easier to organize it.

I think separating the Debian packaging script from the BiT source code would be great (if communicated clearly)
since we don't loose functionality.

Still this requires that the "build Debian package" repo must know where the BiT source repo is located (cloned into).

Maintaining this repo dependency is tricky in Git (Git sub modules etc. are far from being "simple").

Perhaps a "configure" argument to specify the path to the BiT repo would be a solution...

@buhtz
Copy link
Member Author

buhtz commented May 17, 2024

There have been no new arguments on this matter since it was last discussed here. Since this blocks the upcoming release, the active maintainer team has made a decision to move the debian folder into a new repo (e.g. bit-team/backintime-deb). The script in there will be updated to temorary pull in the current backintime repo before building the deb file.

buhtz added a commit to buhtz/backintime that referenced this issue May 27, 2024
@buhtz buhtz removed the Feedback needs user response, may be closed after timeout without a response label Jun 17, 2024
buhtz added a commit that referenced this issue Jul 5, 2024
The folder "debian" and related helper scripts are removed.

It is preserved (including a helper script) in an archive attached to #1548 and can be re-used by PPA maintainers. Official Debian itself does manage its own debian folder.

Close #1548
@buhtz
Copy link
Member Author

buhtz commented Jul 5, 2024

PR #1733 is merged and therefor the folder removed.

It is preserved in this attached archive to be re-used by PPA maintainers. It also contain an extra script to temporary clone the latest upstream release.
backintime_debian-folder_deprecated.zip

buhtz added a commit that referenced this issue Jul 8, 2024
The updateversion.sh script (called via make system) does not touch the removed "debian" folder anymore.

Fixed a problem related to #1548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion decision or consensus needed Distro-Specific only for certain distributions, desktop environments or display servers Infrastructure Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants