Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code related to "filesystem_mounts" and "snapshot_version" field in backup "info" file #1684

Closed
buhtz opened this issue Apr 13, 2024 · 0 comments · Fixed by #1709
Closed

Remove dead code related to "filesystem_mounts" and "snapshot_version" field in backup "info" file #1684

buhtz opened this issue Apr 13, 2024 · 0 comments · Fixed by #1709
Assignees
@buhtz
Labels
Discussion decision or consensus needed Infrastructure Low relevant, but not urgent
Milestone
Release (1.5.0)

Comments

@buhtz
Copy link
Member

buhtz commented Apr 13, 2024 •
edited
Loading

backintime/common/snapshots.py

Line 1140 in d33f35e

i.setStrValue('filesystem_mounts', json.dumps(tools.filesystemMountInfo()))

The field "filesystem_mounts" (and also "snapshot_version") is written into the "info" file of each backup. It is never used anywhere (checked via grep).

  • Remove that field.
  • Remove tools.filesystemMountInfo() because it is used only once at this location.
  • Remove the related unit tests.

My assumption is that this was once added for debug reasons.

EDIT: The same goes for the field "snapshot_version". Never used anywhere.
@buhtz buhtz self-assigned this Apr 13, 2024
@buhtz buhtz added Infrastructure Discussion decision or consensus needed Low relevant, but not urgent labels Apr 13, 2024
@buhtz buhtz added this to the Upcoming release (1.5.0) milestone Apr 13, 2024
@buhtz buhtz mentioned this issue Apr 13, 2024
Merged
@buhtz buhtz changed the title Remove dead code related to "filesystem_mounts" field in backup "info" file Remove dead code related to "filesystem_mounts" and "snapshot_version" field in backup "info" file Apr 21, 2024
@buhtz buhtz mentioned this issue May 2, 2024
Merged
@buhtz buhtz closed this as completed in 19d5ebc May 10, 2024
@buhtz buhtz mentioned this issue Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buhtz buhtz

Labels
Discussion decision or consensus needed Infrastructure Low relevant, but not urgent
Projects
None yet
Milestone
Release (1.5.0)
1 participant
@buhtz