refactor!: Remove "filesystem_mounts" and "snapshot_version" field in backup "info" file #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
commented
May 2, 2024
| """ | ||
| logger.info("Create info file", self) |
There was a problem hiding this comment.
IMHO BIT is to verbose in INFO mode and also give meaningless output.
buhtz
commented
May 2, 2024
| i.setStrValue('snapshot_date', sid.withoutTag) | ||
| i.setStrValue('snapshot_machine', machine) | ||
| i.setStrValue('snapshot_user', user) | ||
| i.setIntValue('snapshot_profile_id', profile_id) | ||
| i.setIntValue('snapshot_tag', sid.tag) | ||
| i.setListValue('user', ('int:uid', 'str:name'), list(self.userCache.items())) | ||
| i.setListValue('group', ('int:gid', 'str:name'), list(self.groupCache.items())) | ||
| i.setStrValue('filesystem_mounts', json.dumps(tools.filesystemMountInfo())) |
There was a problem hiding this comment.
This call to tools.filesystemMountInfo() was my inital trigger to work on this. Discovered this function and wondered for what it might be useful.
buhtz
added
the
PR: Merge after creative-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each snapshot contains an "info" file. This PR remove the two fields "filesystem_mounts" and "snapshot_version" from it because they are not used.
Additionally related code and unit tests are removed or modified.
There is no strict need but I created a changelog entry if it might impacts someone.
Close #1684