Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekday names in Schedule dialog do not respect language settings #1729

Closed
buhtz opened this issue May 27, 2024 · 0 comments · Fixed by #1730
Closed

Weekday names in Schedule dialog do not respect language settings #1729

buhtz opened this issue May 27, 2024 · 0 comments · Fixed by #1730
Assignees
Labels
Bug Cosmetics appearance, icons, themes

Comments

@buhtz
Copy link
Member

buhtz commented May 27, 2024

Manage profiles dialog, General TAB, section Schedule using Every week schedule. The drop down menu with weekday names in it does not respect the current language settings.

Here is an example using "Indonesian" language on a system using "German" locale by default. The GUI is in Indonesian but the names of weekdays are in German.

image

Related code:

for d in range(1, 8):
self.comboScheduleWeekday.addItem(
QIcon(),
datetime.date(2011, 11, 6 + d).strftime("%A"),
d
)

@buhtz buhtz added Bug Cosmetics appearance, icons, themes GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues labels May 27, 2024
@buhtz buhtz self-assigned this May 27, 2024
@buhtz buhtz removed GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues labels May 27, 2024
buhtz added a commit that referenced this issue Jun 1, 2024
Names of weekdays (in schedule settings) and months (in main windows timeline) now correct translated using the language setup.

It is realized with setting locale.LC_TIME based on the language code.

Fix #1729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cosmetics appearance, icons, themes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant