fix(LogViewDialog): Remove Exclude, Copy and Decode context menu #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
added
the
PR: Merge after creative-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the context menu offering Exclude, Copy an Decode (only in ssh encrypt) from log view dialog.
I took over the previous PR #1672 and decided to implemented myself because there was not much progress or respond in the PR. While implementing it I found a tiny sweet little 🤣 checkbox on the bottom of the dialog. See the screen cast. So the decode feature is accessible for the users even without the context menu. Because of that I decided to remove the whole context menu without replacement. The solution was IMHO not very intuitive and elegant.
Fix #1578
Close #1672