Update to PHPUnit 6 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work. I will release version 0.8. today or tommorrow which basically is version 0.7 + the PSR-11 migration. Thus I would kindly ask you to rebase the PR then to make sure the PSR-11 changes make it into your PR. |
|
Done. |
|
Thank you @SenseException for your first contribution to Disco! |
| @@ -18,8 +18,8 @@ | |||
| "bitexpert/slf4psrlog": "^0.1.3" | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/php-code-coverage": "^4.0.1", | |||
| "phpunit/phpunit": "^5.6", | |||
| "phpunit/php-code-coverage": "^5.0.0", | |||
There was a problem hiding this comment.
Why the explicit dependency on php-code-coverage?
There was a problem hiding this comment.
Fair point, we might not need it any more. Did not realize. Thanks for pointing out ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to PHPUnit 6 because it's shiny and of course https://twitter.com/shochdoerfer/status/829235488850587649