Fix to make sure the module will work with Magento 2.1 and 2.2 #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the constructor signature of the
Magento\Framework\App\Router\Base
class changed between 2.1 and 2.2 which makes it impossible to support both versions with the same implementation. To fix this problem theLoginRouter
class does not extend theMagento\Framework\App\Router\Base
any more and simply implements theMagento\Framework\App\RouterInterface
.