Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternative Assertion pattern #80

Closed
bitPogo opened this issue Mar 28, 2022 · 1 comment
Closed

Consider alternative Assertion pattern #80

bitPogo opened this issue Mar 28, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request kmock
Milestone

Comments

@bitPogo
Copy link
Owner

bitPogo commented Mar 28, 2022

Description

The current implemented Assertion feel wrong, aesthetically and and from the handling since they combine actual arguments and boundaries.

Consider instead doing:

assert(mock._someProxy) { hasBeenCalled().times(42) }

or

assert { mock._someProxy.hasBeenCalled().times(42) }

or similar.

This could be a better fit. Additionally this should deprecate the current Assertions and verify. Also consider a non breaking renaming of the current methods of the verifiers to fit the overall naming convention and since they currently act like assertions.

@bitPogo bitPogo added enhancement New feature or request kmock labels Mar 28, 2022
@bitPogo bitPogo added this to the 0.2.0 milestone Mar 28, 2022
@bitPogo bitPogo self-assigned this Mar 28, 2022
@bitPogo
Copy link
Owner Author

bitPogo commented May 30, 2022

Done with release 0.2.0-rc01

@bitPogo bitPogo closed this as completed May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kmock
Projects
None yet
Development

No branches or pull requests

1 participant