Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VerificationChain #117

Merged
merged 5 commits into from
Apr 26, 2022
Merged

Change VerificationChain #117

merged 5 commits into from
Apr 26, 2022

Conversation

bitPogo
Copy link
Owner

@bitPogo bitPogo commented Apr 26, 2022

📌 References

What does the PR achieve/Which part improves the PR?

This renames the exiting VerificationChain into StrictVerificationChain (which is hybrid of verification and assertion) and adds a new VerificationChain to preserve the already existing behaviour. Also expectation methods do not bleed into the code anymore.

🤔 DOD Checklist

  • My code passes the lint checks.
  • My changes are covered with proper tests.
  • All tests are pass.
  • My changes update the documentation.
  • My changes are reflected in the changelog.

@bitPogo bitPogo added this to the 0.2.0 milestone Apr 26, 2022
@bitPogo bitPogo self-assigned this Apr 26, 2022
@github-actions github-actions bot added documentation Improvements or additions to documentation examples kmock labels Apr 26, 2022
@github-actions
Copy link

Warnings
⚠️ Changes should be reflected in the CHANGELOG.adoc
⚠️ Too Big Pull-Request, keep changes smaller

Generated by 🚫 Danger Kotlin against dce7446

@bitPogo bitPogo merged commit f3bab83 into main Apr 26, 2022
@bitPogo bitPogo deleted the feature/add-assertion-context branch April 26, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples kmock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant