Enabled self-hosted build runners.

[mvastarelli]

Modify build configurations to allow builds to go through our self-hosted build agents.

[mvastarelli]

@evan-cohen Can you please take a look at the build logs (https://github.com/bitcobblers/multiminer/actions/runs/1797596167) for this commit? It's now throwing strange linting errors about import/extensions missing a file extension.

Thanks!

[evan-cohen]

At first glance, it seems like a case sensitivity issue. The file is "Handlers.ts", but the import statement reference "./handlers".

[mvastarelli]

At first glance, it seems like a case sensitivity issue. The file is "Handlers.ts", but the import statement reference "./handlers".

Good catch. I forgot that linux was case-sensitive with filenames. Linting is now passing, but now jest is failing with the following error:

1 snapshot file obsolete from 1 test suite. To remove it, run npm test -- -u

Should I just update the build configuration to run tests this way by default?

[evan-cohen]

I'd typically shy away from appending flags to every run of the test command when it comes to snapshots.

From my reading of the docs, it seems like an "obsolete" snapshot is one for which the original .toMatchSnapshot() can no longer be found (often due to the test being renamed or removed).

That said, the specific file referenced in the error seems to be a false positive due to Jest treating the Linux *.snap file as a snapshot -- possibly a manifestation of jestjs/jest#8922. If that artifact is being generated on every build, we may need to reorder the CI steps to avoid generating that file before running Jest. Far from an ideal solution, but running with -u on every test run would essentially invalidate any snapshot testing that we pursue for the project (as it forces existing snapshots to be ignored and regenerated).

[evan-cohen]

We might also be able to disable electron-builder's Snap target if we don't intend to distribute to that platform. I believe I remember you mentioning that we're predominantly targeting Windows, right?

[mvastarelli]

We might also be able to disable electron-builder's Snap target if we don't intend to distribute to that platform. I believe I remember you mentioning that we're predominantly targeting Windows, right?

I have a suspicion that ERB is doing something strange with the way paths in package.json are resolved. Once I updated the testPathIgnorePatterns using relative paths it was able to exclude the errant snap file.

[mvastarelli]

Fixed and fast now.