Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with new create wallet dialogue #151

Open
Rspigler opened this issue Dec 14, 2020 · 6 comments
Open

Issues with new create wallet dialogue #151

Rspigler opened this issue Dec 14, 2020 · 6 comments
Labels
good first issue Good for newcomers UX All about "how to get things done"

Comments

@Rspigler
Copy link
Contributor

As commented here (#96 (comment))

Encrypt Wallet: "Encrypt the wallet. The wallet will be encrypted with a passphrase of your choice." This is incorrect. The wallet is not encrypted, only the private keys are.

Also, this inconsistency:

Checking Disable Private Keys checks Make Blank Wallet (and disables Encrypt Wallet). This is correct. Disable Private Keys should only be checked when Make Blank Wallet is also checked. However, there is a way to have Disable Private Keys checked without having Make Blank Wallet checked (which doesn't make sense).

Check Disable Private Keys, then uncheck the auto-check Make Blank Wallet. You are now left with the settings:

Disabled Encrypt Wallet, checked Disable Private Keys.

This is a setting that you can't enable yourself. (Checking Disable Private Keys also checks Make Blank Wallet normally).

To fix, unchecking the auto-enabled Make Blank Wallet should also uncheck Disable Private Keys and re-enable Encrypt Wallet.
@hebasto
Copy link
Member

hebasto commented Mar 5, 2021

cc @achow101 @Sjors

@hebasto hebasto added the good first issue Good for newcomers label Mar 5, 2021
@hebasto
Copy link
Member

hebasto commented Mar 5, 2021

@Rspigler

Encrypt Wallet: "Encrypt the wallet. The wallet will be encrypted with a passphrase of your choice." This is incorrect. The wallet is not encrypted, only the private keys are.

This wording seems ubiquitous:

Screenshot from 2021-03-05 03-21-59

@Rspigler
Copy link
Contributor Author

Rspigler commented Mar 8, 2021

Where is that screenshot from? Some wallets do encrypt the entire wallet. Bitcoin Core doesn't.

Compiling on master, I still see for the tooltip "Encrypt the wallet. The wallet will be encrypted with a passphrase of your choice", which is incorrect. The wallet is not encrypted, the private keys are, which are two very different things bitcoin/bitcoin#18085

There are also various text boxes after encrypting the wallet which are incorrect "You wallet is now encrypted" etc.

@hebasto
Copy link
Member

hebasto commented Mar 8, 2021

@Rspigler

Where is that screenshot from?

The Bitcoin Core.

Create a wallet without encryption. then in menu go to "Settings" -> "Encrypt Wallet".

@Rspigler
Copy link
Contributor Author

Rspigler commented Mar 8, 2021

That should be changed as well then. For example, metadata is not encrypted.

@jarolrod jarolrod mentioned this issue Mar 10, 2021
Merged
maflcko pushed a commit that referenced this issue Mar 26, 2021
Merge #243: fix issue when disabling the auto-enabled blank wallet ch…
19e3e65 
…eckbox

915e341 qt: fix issue when disabling the auto-enabled blank wallet checkbox (Jarol Rodriguez)

Pull request description:

  As detailed by #151, On `master` a user can create the confusing scenario where you have a disabled `Encrypt Wallet` checkbox and a selected `Disable Private Keys` checkbox after unselecting the auto-enabled `Blank Wallet` checkbox.

  This commit makes it so that when the `Blank Wallet` checkbox is auto-selected after the user selects `Disable Private keys`, unselecting it will also unselect the `Disable Private Keys` checkbox, which in turn re-enables the `Encrypt Wallet` checkbox.

  Below are screenshots comparing the behavior of selecting `Disable Private Keys` then unselecting the `Blank Wallet` between `master` and this `PR`:

  **Master:**
  | Select `Disable Private Keys` | Unselect `Blank Wallet` |
  | ----------------------------- | ------------------------ |
  | ![Screen Shot 2021-03-09 at 7 57 14 PM](https://user-images.githubusercontent.com/23396902/110560141-77405a80-8113-11eb-9285-5acba6241dcf.png) |   ![Screen Shot 2021-03-09 at 7 57 31 PM](https://user-images.githubusercontent.com/23396902/110560159-81faef80-8113-11eb-9b37-086aa39ecb9f.png)    |

  **PR:**
  | Select `Disable Private Keys` | Unselect `Blank Wallet` |
  | ----------------------------- | ------------------------ |
  | ![Screen Shot 2021-03-09 at 7 34 12 PM](https://user-images.githubusercontent.com/23396902/110560379-e3bb5980-8113-11eb-899a-3a4c6a1bc115.png) | ![Screen Shot 2021-03-09 at 7 34 20 PM](https://user-images.githubusercontent.com/23396902/110560412-f170df00-8113-11eb-8bd0-f7fe6fc0d739.png) |

ACKs for top commit:
  hebasto:
    ACK 915e341
  Talkless:
    ACK 915e341

Tree-SHA512: ce6ecbc35b94a08cabf0b8a24dbdfc874d82cc8918cc8623dce8172c7fc9c75d63a13b036bae5f7ab2c090f8d020574a542285d1651600813faf5d91e2506a8d
@hebasto hebasto added the UX All about "how to get things done" label May 1, 2021
@Rspigler Rspigler mentioned this issue May 20, 2021
Closed
@hebasto hebasto mentioned this issue Aug 4, 2021
Closed
@maflcko
Copy link
Contributor

maflcko commented May 22, 2024

See also #722 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers UX All about "how to get things done"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maflcko @Rspigler @hebasto