Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace QRegExp with QRegularExpression #578

Closed
hebasto opened this issue Apr 8, 2022 · 1 comment · Fixed by #620
Closed

Replace QRegExp with QRegularExpression #578

hebasto opened this issue Apr 8, 2022 · 1 comment · Fixed by #620
Labels
good first issue Good for newcomers Qt 6 Transition to Qt 6 Refactoring

Comments

@hebasto
Copy link
Member

hebasto commented Apr 8, 2022

QRegularExpression

implements Perl-compatible regular expressions. It fully supports Unicode.

QRegExp

is modeled on Perl's regexp language. It fully supports Unicode.

... the new QRegularExpression class ... is recommended in place of QRegExp.

The most valued benefit will come when migrating to Qt 6, where QRegExp requires usage of an additional Core5Compat module.

Instead, all use cases of QRegExp could be ported to QRegularExpression.

Useful skills:

basic C++, Qt, regular expressions

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.
@hebasto hebasto added good first issue Good for newcomers Refactoring labels Apr 8, 2022
@hebasto hebasto mentioned this issue Apr 8, 2022
Closed
5 tasks
@hebasto hebasto added the Qt 6 Transition to Qt 6 label Apr 12, 2022
@prusnak prusnak mentioned this issue Apr 15, 2022
Closed
@prusnak
Copy link
Contributor

prusnak commented Apr 15, 2022

PR in #585

This was referenced Apr 23, 2022
Merged
Merged
hebasto added a commit that referenced this issue May 9, 2022
@hebasto
Merge #591: test: Add tests for tableView in AddressBookPage dialog
3dd95cb 
1506913 qt, test: Add tests for `tableView` in `AddressBookPage` dialog (Hennadii Stepanov)
edae3ab qt: No need to force Qt::QueuedConnection for NotifyAddressBookChanged (Hennadii Stepanov)

Pull request description:

  This PR is a prerequisite for more thorough testing of filtering in the `AddressBookPage` class in context of #578 and #585.

  Required for #592.

ACKs for top commit:
  promag:
    Code review ACK 1506913.

Tree-SHA512: 86986d47606cbd54d813436c7afb21894e2200b6d3042a7aa0b5e84821c765bd68b14ad38a445069891ab33f2d7bcd4933b8373e14e9afb0c91f1a6ddf4da740
sidhujag pushed a commit to syscoin/syscoin that referenced this issue May 9, 2022
@hebasto
Merge bitcoin-core/gui#591: test: Add tests for tableView in `Addre…
049283e 
…ssBookPage` dialog

1506913 qt, test: Add tests for `tableView` in `AddressBookPage` dialog (Hennadii Stepanov)
edae3ab qt: No need to force Qt::QueuedConnection for NotifyAddressBookChanged (Hennadii Stepanov)

Pull request description:

  This PR is a prerequisite for more thorough testing of filtering in the `AddressBookPage` class in context of bitcoin-core/gui#578 and bitcoin-core/gui#585.

  Required for bitcoin-core/gui#592.

ACKs for top commit:
  promag:
    Code review ACK 1506913.

Tree-SHA512: 86986d47606cbd54d813436c7afb21894e2200b6d3042a7aa0b5e84821c765bd68b14ad38a445069891ab33f2d7bcd4933b8373e14e9afb0c91f1a6ddf4da740
hebasto added a commit that referenced this issue May 24, 2022
@hebasto
Merge #593: Getting ready to Qt 6 (8/n). Use QRegularExpression in …
8898906 
…`AddressBookSortFilterProxyModel` class

e280087 qt: Use `QRegularExpression` in `AddressBookSortFilterProxyModel` class (Hennadii Stepanov)
5c5d8f2 qt, test: Add tests for searching in `AddressBookPage` dialog (Hennadii Stepanov)

Pull request description:

  This is a step in [migration](bitcoin/bitcoin#24798) to Qt 6.

  Related:
  - #578
  - #585

  No behavior change. To ensure this, tests have been added.

ACKs for top commit:
  hebasto:
    > tACK [e280087](e280087) on Ubuntu 21.10 Qt 5.15.2
  promag:
    Tested ACK e280087 with Qt6 on macOS 12 M1.
  w0xlt:
    tACK e280087 on Ubuntu 21.10 Qt 5.15.2
  jarolrod:
    Tested ACK e280087 on M1 mac, x86 mac, x86 Linux with Qt5 and separately with Qt6

Tree-SHA512: 664baacc1504deb2f7fa651ea4a44f3942f5c9058befe4d2ce292beed032d4b1697710cfd10c0909602d8a4a6eeb680414e4a1f56d2038478c1ae2f34965d74f
@jarolrod jarolrod mentioned this issue May 25, 2022
Closed
sidhujag pushed a commit to syscoin/syscoin that referenced this issue May 28, 2022
@hebasto
Merge bitcoin-core/gui#593: Getting ready to Qt 6 (8/n). Use `QRegula…
c24c674 
…rExpression` in `AddressBookSortFilterProxyModel` class

e280087 qt: Use `QRegularExpression` in `AddressBookSortFilterProxyModel` class (Hennadii Stepanov)
5c5d8f2 qt, test: Add tests for searching in `AddressBookPage` dialog (Hennadii Stepanov)

Pull request description:

  This is a step in [migration](bitcoin#24798) to Qt 6.

  Related:
  - bitcoin-core/gui#578
  - bitcoin-core/gui#585

  No behavior change. To ensure this, tests have been added.

ACKs for top commit:
  hebasto:
    > tACK [e280087](bitcoin-core/gui@e280087) on Ubuntu 21.10 Qt 5.15.2
  promag:
    Tested ACK e280087 with Qt6 on macOS 12 M1.
  w0xlt:
    tACK bitcoin-core/gui@e280087 on Ubuntu 21.10 Qt 5.15.2
  jarolrod:
    Tested ACK bitcoin-core/gui@e280087 on M1 mac, x86 mac, x86 Linux with Qt5 and separately with Qt6

Tree-SHA512: 664baacc1504deb2f7fa651ea4a44f3942f5c9058befe4d2ce292beed032d4b1697710cfd10c0909602d8a4a6eeb680414e4a1f56d2038478c1ae2f34965d74f
@w0xlt w0xlt mentioned this issue Jun 20, 2022
Merged
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers Qt 6 Transition to Qt 6 Refactoring
Projects
None yet
Milestone
No milestone
2 participants
@prusnak @hebasto