refactor: Replace deprecated Qt::SystemLocale{Short,Long}Date #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this identified with the latest 5.15.2? |
5.15.2 was released on 2020-11-20, but the recent Qt the Homebrew provides still 5.15.1. Warnings are fired on 5.15.1:
Did not test on 5.15.2. UPDATE: Looking into code it seems I just missed those warnings in #46 🤷♂️ |
jarolrod
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Tested ACK 86b1ab6 on MacOS 10.15.7 and Arch Linux both with Qt 5.15.1
- Compiled both Master and PR with
make -j{n} |& tee compile.txt, then grepped this file withgrep -r "deprecated" - Can confirm that master raises these deprecation warnings and the PR fixes them
I also compiled with Qt 5.15.2 on Linux and can confirm that master still raises, and PR fixes. Furthermore, there are no new deprecated warnings.
jonasschnelli
approved these changes
Dec 1, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 1, 2020
…cale{Short,Long}Date
86b1ab6 refactor: Replace deprecated Qt::SystemLocale{Short,Long}Date (Hennadii Stepanov)
Pull request description:
As all deprecated warning in Qt 5.15.0 were eliminated in #46, Qt 5.15.1 introduced another one that is fixed in this PR.
Required for bitcoin#20182.
Details in Qt docs:
- https://doc.qt.io/qt-5/qdatetime.html#toString-1
- https://doc.qt.io/qt-5/qdate.html#toString-1
ACKs for top commit:
jarolrod:
Tested ACK 86b1ab6 on MacOS 10.15.7 and Arch Linux both with Qt 5.15.1
jonasschnelli:
Tested ACK 86b1ab6
Tree-SHA512: 1dbba8ee70c895bf58317172a9901cdbe5503b1d6258f51caaae88d88d332d9fbd4697c995192d31e3618ddfd532c5f5881289b3af1184422e5a9263a1224115
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all deprecated warning in Qt 5.15.0 were eliminated in #46, Qt 5.15.1 introduced another one that is fixed in this PR.
Required for bitcoin/bitcoin#20182.
Details in Qt docs: