Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show unused widgets at startup #439

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Do not show unused widgets at startup #439

merged 1 commit into from
Sep 30, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Sep 29, 2021

On master (8d83f9c), when starting without wallets the labelWalletEncryptionIcon and
labelWalletHDStatusIcon widgets are not used but still visible as empty space:

Screenshot from 2021-09-29 21-59-22

If one opens any wallet then closes it, the widget layout becomes densed:

Screenshot from 2021-09-29 22-05-31

This PR makes widget layout densed at startup.

Fixes #428.

@hebasto
qt: Do not show unused widgets at startup
489060d 
When starting without wallets the labelWalletEncryptionIcon and
labelWalletHDStatusIcon widgets are not required.
@hebasto hebasto mentioned this pull request Sep 29, 2021
Closed
@hebasto hebasto added Design UI All about "look and feel" and removed Design labels Sep 29, 2021
@katesalazar
Copy link
Contributor

Only watched it in action on macOS, but it works. Thank you!

jarolrod
jarolrod reviewed Sep 30, 2021
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 489060d

Confirmed the related bug (#428) and tested that this fixes it. The issue here is that we aren't hiding the unused icons. The PR fixes the issue by hiding them. When they are needed again (when you create a wallet), they are properly shown. Tested on macOS 12.

Bug on master PR Create Wallet, Icons will still Appear
Screen Shot 2021-09-29 at 9 15 46 PM Screen Shot 2021-09-29 at 9 16 55 PM Screen Shot 2021-09-29 at 9 17 21 PM

promag
promag reviewed Sep 30, 2021
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 489060d.

@hebasto hebasto merged commit f529290 into bitcoin-core:master Sep 30, 2021
@hebasto hebasto deleted the 210929-hide branch September 30, 2021 08:17
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 30, 2021
@hebasto
Merge bitcoin-core/gui#439: Do not show unused widgets at startup
1e56bd5 
489060d qt: Do not show unused widgets at startup (Hennadii Stepanov)

Pull request description:

  On master (8d83f9c), when starting without wallets the `labelWalletEncryptionIcon` and
  `labelWalletHDStatusIcon` widgets are not used but still visible as empty space:

  ![Screenshot from 2021-09-29 21-59-22](https://user-images.githubusercontent.com/32963518/135332107-f02db936-3c3a-436b-9e78-c5721df8852b.png)

  If one opens any wallet then closes it, the widget layout becomes densed:

  ![Screenshot from 2021-09-29 22-05-31](https://user-images.githubusercontent.com/32963518/135332650-83787bc4-fa8e-417e-8d53-a9fdb1c8bfc9.png)

  This PR makes widget layout densed at startup.

  Fixes #428.

ACKs for top commit:
  jarolrod:
    ACK 489060d
  promag:
    Code review ACK 489060d.

Tree-SHA512: bda7195225ecd203bb3269ebe7fc264aaf7f57b922deb83a04127584a5d6123950741fb431161523e84630927c2f617e85c085bbbe75ad8559da7b2947de1bdd
@katesalazar
Copy link
Contributor

katesalazar commented Oct 6, 2021 •
edited
Loading

Port it back to 22 please? And maybe 0.21 as well?

(If backport policy includes this kind of unimportant stuff)

@laanwj
Copy link
Member

laanwj commented Oct 14, 2021

@katesalazar Do you have a specific rationale for requesting this PR to be backported? (It doesn't help that you call it unimportant yourself 😄 )

@katesalazar
Copy link
Contributor

@laanwj I could risk suggesting there is no "UI issues" really,
but "UI features" and "UI bugs",
then an "UI bug" is relatively unimportant to almost every other kind of bug,
still, as a bug, subject to back porting.

@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@promag promag promag left review comments

@jarolrod jarolrod jarolrod left review comments

Assignees
No one assigned
Labels
UI All about "look and feel"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird status icons stacking - empty placeholders
5 participants
@hebasto @katesalazar @laanwj @promag @jarolrod